Re: [PATCH 2/3] PCI/AER: Actually get the root port

From: kernel test robot <lkp@intel.com>
To: Keith Busch <kbusch@kernel.org>,
	linux-pci@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>
Cc: kbuild-all@lists.01.org, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 2/3] PCI/AER: Actually get the root port
Date: Fri, 18 Dec 2020 07:15:25 +0800	[thread overview]
Message-ID: <202012180722.adlEqbko-lkp@intel.com> (raw)
In-Reply-To: <20201217171431.502030-2-kbusch@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 4295 bytes --]

Hi Keith,

I love your patch! Perhaps something to improve:

[auto build test WARNING on pci/next]
[also build test WARNING on next-20201217]
[cannot apply to v5.10]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Keith-Busch/PCI-ERR-Clear-status-of-the-reporting-device/20201218-011952
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: parisc-randconfig-r014-20201217 (attached as .config)
compiler: hppa64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8f1a820daa9ec2e25dfbdd5b4752df01e849b3aa
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Keith-Busch/PCI-ERR-Clear-status-of-the-reporting-device/20201218-011952
        git checkout 8f1a820daa9ec2e25dfbdd5b4752df01e849b3aa
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/pci/pcie/aer.c: In function 'aer_root_reset':
>> drivers/pci/pcie/aer.c:15:21: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Wformat=]
      15 | #define pr_fmt(fmt) "AER: " fmt
         |                     ^~~~~~~
   drivers/pci/pcie/aer.c:16:17: note: in expansion of macro 'pr_fmt'
      16 | #define dev_fmt pr_fmt
         |                 ^~~~~~
   include/linux/dev_printk.h:118:17: note: in expansion of macro 'dev_fmt'
     118 |  _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                 ^~~~~~~
   include/linux/pci.h:2417:37: note: in expansion of macro 'dev_info'
    2417 | #define pci_info(pdev, fmt, arg...) dev_info(&(pdev)->dev, fmt, ##arg)
         |                                     ^~~~~~~~
   drivers/pci/pcie/aer.c:1417:3: note: in expansion of macro 'pci_info'
    1417 |   pci_info(dev, "%s Port link has been reset (%d)\n", rc,
         |   ^~~~~~~~
   drivers/pci/pcie/aer.c:1417:19: note: format string is defined here
    1417 |   pci_info(dev, "%s Port link has been reset (%d)\n", rc,
         |                  ~^
         |                   |
         |                   char *
         |                  %d
>> drivers/pci/pcie/aer.c:15:21: warning: format '%d' expects argument of type 'int', but argument 4 has type 'char *' [-Wformat=]
      15 | #define pr_fmt(fmt) "AER: " fmt
         |                     ^~~~~~~
   drivers/pci/pcie/aer.c:16:17: note: in expansion of macro 'pr_fmt'
      16 | #define dev_fmt pr_fmt
         |                 ^~~~~~
   include/linux/dev_printk.h:118:17: note: in expansion of macro 'dev_fmt'
     118 |  _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                 ^~~~~~~
   include/linux/pci.h:2417:37: note: in expansion of macro 'dev_info'
    2417 | #define pci_info(pdev, fmt, arg...) dev_info(&(pdev)->dev, fmt, ##arg)
         |                                     ^~~~~~~~
   drivers/pci/pcie/aer.c:1417:3: note: in expansion of macro 'pci_info'
    1417 |   pci_info(dev, "%s Port link has been reset (%d)\n", rc,
         |   ^~~~~~~~
   drivers/pci/pcie/aer.c:1417:48: note: format string is defined here
    1417 |   pci_info(dev, "%s Port link has been reset (%d)\n", rc,
         |                                               ~^
         |                                                |
         |                                                int
         |                                               %s

vim +15 drivers/pci/pcie/aer.c

9cc6f75b27e76d3 Frederick Lawler 2019-05-07 @15  #define pr_fmt(fmt) "AER: " fmt
9cc6f75b27e76d3 Frederick Lawler 2019-05-07  16  #define dev_fmt pr_fmt
9cc6f75b27e76d3 Frederick Lawler 2019-05-07  17  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31159 bytes --]