From: Bjorn Helgaas <helgaas@kernel.org>
To: Alexander Lobakin <alobakin@pm.me>, Vidya Sagar <vidyas@nvidia.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Jingoo Han <jingoohan1@gmail.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Rob Herring <robh@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH pci] PCI: dwc: fix inverted condition of DMA mask setup warning
Date: Wed, 23 Dec 2020 12:58:27 -0600 [thread overview]
Message-ID: <20201223185827.GA312001@bjorn-Precision-5520> (raw)
In-Reply-To: <20201222150708.67983-1-alobakin@pm.me>
On Tue, Dec 22, 2020 at 03:07:43PM +0000, Alexander Lobakin wrote:
> Commit 660c486590aa ("PCI: dwc: Set 32-bit DMA mask for MSI target
> address allocation") added dma_mask_set() call to explicitly set
> 32-bit DMA mask for MSI message mapping, but for now it throws a
> warning on ret == 0, while dma_set_mask() returns 0 in case of
> success.
> Fix this by inverting the condition.
>
> Misc: remove redundant braces around single statement.
>
> Fixes: 660c486590aa ("PCI: dwc: Set 32-bit DMA mask for MSI target address allocation")
> Signed-off-by: Alexander Lobakin <alobakin@pm.me>
I joined the string to make it greppable and applied to for-linus for
v5.11, thanks!
Vidya, speak up if this isn't right. I assume you should have seen
this spurious warning while testing 660c486590aa.
> ---
> drivers/pci/controller/dwc/pcie-designware-host.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
> index 516b151e0ef3..fa40cc2e376f 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> @@ -397,12 +397,11 @@ int dw_pcie_host_init(struct pcie_port *pp)
> pp);
>
> ret = dma_set_mask(pci->dev, DMA_BIT_MASK(32));
> - if (!ret) {
> + if (ret)
> dev_warn(pci->dev,
> "Failed to set DMA mask to 32-bit. "
> "Devices with only 32-bit MSI support"
> " may not work properly\n");
> - }
>
> pp->msi_data = dma_map_single_attrs(pci->dev, &pp->msi_msg,
> sizeof(pp->msi_msg),
> --
> 2.29.2
>
>
prev parent reply other threads:[~2020-12-23 18:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 15:07 [PATCH pci] PCI: dwc: fix inverted condition of DMA mask setup warning Alexander Lobakin
2020-12-23 18:58 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201223185827.GA312001@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=alobakin@pm.me \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).