From: Keith Busch <kbusch@kernel.org>
To: linux-pci@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>
Cc: Keith Busch <kbusch@kernel.org>, Sean V Kelley <sean.v.kelley@intel.com>
Subject: [PATCHv2 2/5] PCI/AER: Actually get the root port
Date: Mon, 4 Jan 2021 15:02:57 -0800 [thread overview]
Message-ID: <20210104230300.1277180-3-kbusch@kernel.org> (raw)
In-Reply-To: <20210104230300.1277180-1-kbusch@kernel.org>
The pci_dev parameter given to aer_root_reset() may be a downstream port
rather than the root port. Get the root port from the provided device in
order to clear the root's aer status.
Acked-by: Sean V Kelley <sean.v.kelley@intel.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
drivers/pci/pcie/aer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
index 77b0f2c45bc0..3fd4aaaa627e 100644
--- a/drivers/pci/pcie/aer.c
+++ b/drivers/pci/pcie/aer.c
@@ -1388,7 +1388,7 @@ static pci_ers_result_t aer_root_reset(struct pci_dev *dev)
if (type == PCI_EXP_TYPE_RC_END)
root = dev->rcec;
else
- root = dev;
+ root = pcie_find_root_port(dev);
/*
* If the platform retained control of AER, an RCiEP may not have
--
2.24.1
next prev parent reply other threads:[~2021-01-04 23:03 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 23:02 [PATCHv2 0/5] aer handling fixups Keith Busch
2021-01-04 23:02 ` [PATCHv2 1/5] PCI/ERR: Clear status of the reporting device Keith Busch
2021-01-04 23:02 ` Keith Busch [this message]
2021-01-04 23:02 ` [PATCHv2 3/5] PCI/ERR: Retain status from error notification Keith Busch
2021-03-03 5:34 ` Williams, Dan J
2021-03-03 5:46 ` Kuppuswamy, Sathyanarayanan
2021-03-04 20:01 ` Keith Busch
2021-03-04 22:11 ` Dan Williams
[not found] ` <23551edc-965c-21dc-0da8-a492c27c362d@intel.com>
2021-03-04 22:59 ` Dan Williams
2021-03-04 23:19 ` Kuppuswamy, Sathyanarayanan
2021-03-05 0:23 ` Dan Williams
2021-03-05 0:54 ` Keith Busch
2021-01-04 23:02 ` [PATCHv2 4/5] PCI/AER: Specify the type of port that was reset Keith Busch
2021-01-04 23:03 ` [PATCHv2 5/5] PCI/portdrv: Report reset for frozen channel Keith Busch
2021-01-05 14:21 ` [PATCHv2 0/5] aer handling fixups Hinko Kocevar
2021-01-05 15:06 ` Hinko Kocevar
2021-01-05 18:33 ` Keith Busch
2021-01-05 23:07 ` Kelley, Sean V
2021-01-07 21:42 ` Keith Busch
2021-01-08 9:38 ` Hinko Kocevar
2021-01-11 13:39 ` Hinko Kocevar
2021-01-11 16:37 ` Keith Busch
2021-01-11 20:02 ` Hinko Kocevar
2021-01-11 22:09 ` Keith Busch
[not found] ` <ed8256dd-d70d-b8dc-fdc0-a78b9aa3bbd9@ess.eu>
2021-01-12 19:27 ` Keith Busch
2021-01-12 22:19 ` Hinko Kocevar
2021-01-12 23:17 ` Keith Busch
2021-01-18 8:00 ` Hinko Kocevar
2021-01-19 18:28 ` Keith Busch
2021-02-03 0:03 ` Keith Busch
2021-02-04 8:35 ` Hinko Kocevar
2021-02-08 12:55 ` Hedi Berriche
2021-02-09 23:06 ` Bjorn Helgaas
2021-02-10 4:05 ` Keith Busch
2021-02-10 21:38 ` Bjorn Helgaas
2021-02-10 9:36 ` Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210104230300.1277180-3-kbusch@kernel.org \
--to=kbusch@kernel.org \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sean.v.kelley@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).