From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0173C433E6 for ; Mon, 18 Jan 2021 18:09:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A9C9221F7 for ; Mon, 18 Jan 2021 18:09:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407439AbhARSIi (ORCPT ); Mon, 18 Jan 2021 13:08:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:53874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407409AbhARSIX (ORCPT ); Mon, 18 Jan 2021 13:08:23 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9FF7622CB1; Mon, 18 Jan 2021 18:07:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610993254; bh=aYqnCH8ScQZyhnw4khBM/XTmvc6Q+AF6HwsT7VnMuBY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZdBeo7tb3Ir+lehb9m4RNF4rWVlAfddMINiVY7XsdcbdP6NskbVbj8ihSHT1S34Jj LETXBFretfm0PT2EXSK/pGL4AumHbN1XVTpwC5jkYypIC98XBuhFTVTV/5TnJEfVJC 9GPTMjXaQmxHHW5gp+djFyzjOD7qpfcHGRH997cXfC5EnOvvfvFMGmD4kw3MjNTvbW Qfw9LAGD1OM+RAoBNt7xAMRNmUMGIsqO7GFTbT3rlrfW0jblKbsbPhLEaJ0b3iRpwU EA+fqmvVpLrLULJ54HlX8xy6y9fquv57VOeNiEJ/kLv75f6OnAbSdUEMtK4whEi2wu j3kcl10cJlpWw== Date: Mon, 18 Jan 2021 10:07:32 -0800 From: Jakub Kicinski To: Leon Romanovsky Cc: Bjorn Helgaas , Saeed Mahameed , Jason Gunthorpe , linux-pci@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, Don Dutile , Alex Williamson , Alexander Duyck Subject: Re: [PATCH mlx5-next v2 0/5] Dynamically assign MSI-X vectors count Message-ID: <20210118100732.51803b06@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210117072441.GA1242829@unreal> References: <20210114103140.866141-1-leon@kernel.org> <20210114095128.0f388f08@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210117054409.GQ944463@unreal> <20210117072441.GA1242829@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Sun, 17 Jan 2021 09:24:41 +0200 Leon Romanovsky wrote: > On Sun, Jan 17, 2021 at 07:44:09AM +0200, Leon Romanovsky wrote: > > On Thu, Jan 14, 2021 at 09:51:28AM -0800, Jakub Kicinski wrote: > > > On Thu, 14 Jan 2021 12:31:35 +0200 Leon Romanovsky wrote: > > > > The number of MSI-X vectors is PCI property visible through lspci, that > > > > field is read-only and configured by the device. > > > > > > > > The static assignment of an amount of MSI-X vectors doesn't allow utilize > > > > the newly created VF because it is not known to the device the future load > > > > and configuration where that VF will be used. > > > > > > > > The VFs are created on the hypervisor and forwarded to the VMs that have > > > > different properties (for example number of CPUs). > > > > > > > > To overcome the inefficiency in the spread of such MSI-X vectors, we > > > > allow the kernel to instruct the device with the needed number of such > > > > vectors, before VF is initialized and bounded to the driver. > > > > > > > > > Hi Leon! > > > > > > Looks like you got some missing kdoc here, check out the test in > > > patchwork so we don't need to worry about this later: > > > > > > https://patchwork.kernel.org/project/netdevbpf/list/?series=414497 > > > > Thanks Jakub, > > > > I'll add kdocs to internal mlx5 functions. > > IMHO, they are useless. It's just scripts/kernel-doc, and it's checking if the kdoc is _valid_, your call if you want to add kdoc, just a comment, or nothing at all. > At the end, it looks like CI false alarm. > > drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c:81: warning: Function parameter or member 'dev' not described in 'mlx5_set_msix_vec_count' > drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c:81: warning: Function parameter or member 'function_id' not described in 'mlx5_set_msix_vec_count' > drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c:81: warning: Function parameter or member 'msix_vec_count' not described in 'mlx5_set_msix_vec_count' > New warnings added > > The function mlx5_set_msix_vec_count() is documented. > +/** > + * mlx5_set_msix_vec_count() - Set dynamically allocated MSI-X to the VF > + * @dev - PF to work on > + * @function_id - internal PCI VF function id > + * @msix_vec_count - Number of MSI-X to set > + **/ > +int mlx5_set_msix_vec_count(struct mlx5_core_dev *dev, int function_id, > + int msix_vec_count) > https://patchwork.kernel.org/project/netdevbpf/patch/20210114103140.866141-5-leon@kernel.org/ AFAIU that's not valid kdoc, I _think_ you need to replace ' -' with ':' for arguments (not my rules).