From: Bjorn Helgaas <helgaas@kernel.org>
To: Kishon Vijay Abraham I <kishon@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Corbet <corbet@lwn.net>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Arnd Bergmann <arnd@arndb.de>, Jon Mason <jdmason@kudzu.us>,
Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <allenbh@gmail.com>, Tom Joseph <tjoseph@cadence.com>,
Rob Herring <robh@kernel.org>,
linux-pci@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com
Subject: Re: [PATCH v9 10/17] PCI: endpoint: Allow user to create sub-directory of 'EPF Device' directory
Date: Tue, 19 Jan 2021 12:35:19 -0600 [thread overview]
Message-ID: <20210119183519.GA2496938@bjorn-Precision-5520> (raw)
In-Reply-To: <20210119183405.GA2496684@bjorn-Precision-5520>
On Tue, Jan 19, 2021 at 12:34:07PM -0600, Bjorn Helgaas wrote:
> [cc->to Greg]
>
> On Mon, Jan 04, 2021 at 08:59:02PM +0530, Kishon Vijay Abraham I wrote:
> > Documentation/PCI/endpoint/pci-endpoint-cfs.rst explains how a user
> > has to create a directory in-order to create a 'EPF Device' that
> > can be configured/probed by 'EPF Driver'.
> >
> > Allow user to create a sub-directory of 'EPF Device' directory for
> > any function specific attributes that has to be exposed to the user.
>
> Maybe add an example sysfs path in the commit log?
>
> Seems like there's restriction on hierarchy depth in sysfs, but I
> don't remember the details. Moved Greg to "to" in case he wants to
> comment.
Oh, I see this is for *configfs*, not for *sysfs*. Sorry for the
noise.
> > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> > ---
> > drivers/pci/endpoint/pci-ep-cfs.c | 23 +++++++++++++++++++++++
> > include/linux/pci-epf.h | 3 +++
> > 2 files changed, 26 insertions(+)
> >
> > diff --git a/drivers/pci/endpoint/pci-ep-cfs.c b/drivers/pci/endpoint/pci-ep-cfs.c
> > index 8f750961d6ab..f3a8b833b479 100644
> > --- a/drivers/pci/endpoint/pci-ep-cfs.c
> > +++ b/drivers/pci/endpoint/pci-ep-cfs.c
> > @@ -490,7 +490,29 @@ static struct configfs_item_operations pci_epf_ops = {
> > .release = pci_epf_release,
> > };
> >
> > +static struct config_group *pci_epf_type_make(struct config_group *group,
> > + const char *name)
> > +{
> > + struct pci_epf_group *epf_group = to_pci_epf_group(&group->cg_item);
> > + struct config_group *epf_type_group;
> > +
> > + epf_type_group = pci_epf_type_add_cfs(epf_group->epf, group);
> > + return epf_type_group;
> > +}
> > +
> > +static void pci_epf_type_drop(struct config_group *group,
> > + struct config_item *item)
> > +{
> > + config_item_put(item);
> > +}
> > +
> > +static struct configfs_group_operations pci_epf_type_group_ops = {
> > + .make_group = &pci_epf_type_make,
> > + .drop_item = &pci_epf_type_drop,
> > +};
> > +
> > static const struct config_item_type pci_epf_type = {
> > + .ct_group_ops = &pci_epf_type_group_ops,
> > .ct_item_ops = &pci_epf_ops,
> > .ct_attrs = pci_epf_attrs,
> > .ct_owner = THIS_MODULE,
> > @@ -553,6 +575,7 @@ static struct config_group *pci_epf_make(struct config_group *group,
> > goto free_name;
> > }
> >
> > + epf->group = &epf_group->group;
> > epf_group->epf = epf;
> >
> > kfree(epf_name);
> > diff --git a/include/linux/pci-epf.h b/include/linux/pci-epf.h
> > index b241e7dd171f..6833e2160ef1 100644
> > --- a/include/linux/pci-epf.h
> > +++ b/include/linux/pci-epf.h
> > @@ -9,6 +9,7 @@
> > #ifndef __LINUX_PCI_EPF_H
> > #define __LINUX_PCI_EPF_H
> >
> > +#include <linux/configfs.h>
> > #include <linux/device.h>
> > #include <linux/mod_devicetable.h>
> > #include <linux/pci.h>
> > @@ -128,6 +129,7 @@ struct pci_epf_bar {
> > * EPC device
> > * @sec_epc_bar: represents the BAR of EPF device associated with secondary EPC
> > * @sec_epc_func_no: unique (physical) function number within the secondary EPC
> > + * @group: configfs group associated with the EPF device
> > */
> > struct pci_epf {
> > struct device dev;
> > @@ -150,6 +152,7 @@ struct pci_epf {
> > struct list_head sec_epc_list;
> > struct pci_epf_bar sec_epc_bar[6];
> > u8 sec_epc_func_no;
> > + struct config_group *group;
> > };
> >
> > /**
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2021-01-19 18:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 15:28 [PATCH v9 00/17] Implement NTB Controller using multiple PCI EP Kishon Vijay Abraham I
2021-01-04 15:28 ` [PATCH v9 01/17] Documentation: PCI: Add specification for the *PCI NTB* function device Kishon Vijay Abraham I
2021-01-19 18:34 ` Bjorn Helgaas
2021-01-22 14:18 ` Kishon Vijay Abraham I
2021-01-28 12:11 ` Lorenzo Pieralisi
2021-01-28 13:34 ` Kishon Vijay Abraham I
2021-01-29 1:05 ` Randy Dunlap
2021-01-29 5:10 ` Kishon Vijay Abraham I
2021-01-04 15:28 ` [PATCH v9 02/17] PCI: endpoint: Make *_get_first_free_bar() take into account 64 bit BAR Kishon Vijay Abraham I
2021-01-04 15:28 ` [PATCH v9 03/17] PCI: endpoint: Add helper API to get the 'next' unreserved BAR Kishon Vijay Abraham I
2021-01-04 15:28 ` [PATCH v9 04/17] PCI: endpoint: Make *_free_bar() to return error codes on failure Kishon Vijay Abraham I
2021-01-04 15:28 ` [PATCH v9 05/17] PCI: endpoint: Remove unused pci_epf_match_device() Kishon Vijay Abraham I
2021-01-04 15:28 ` [PATCH v9 06/17] PCI: endpoint: Add support to associate secondary EPC with EPF Kishon Vijay Abraham I
2021-01-04 15:28 ` [PATCH v9 07/17] PCI: endpoint: Add support in configfs to associate two EPCs " Kishon Vijay Abraham I
2021-01-04 15:29 ` [PATCH v9 08/17] PCI: endpoint: Add pci_epc_ops to map MSI irq Kishon Vijay Abraham I
2021-01-04 15:29 ` [PATCH v9 09/17] PCI: endpoint: Add pci_epf_ops for epf drivers to expose function specific attrs Kishon Vijay Abraham I
2021-01-04 15:29 ` [PATCH v9 10/17] PCI: endpoint: Allow user to create sub-directory of 'EPF Device' directory Kishon Vijay Abraham I
2021-01-19 18:34 ` Bjorn Helgaas
2021-01-19 18:35 ` Bjorn Helgaas [this message]
2021-01-19 18:38 ` Greg Kroah-Hartman
2021-01-04 15:29 ` [PATCH v9 11/17] PCI: cadence: Implement ->msi_map_irq() ops Kishon Vijay Abraham I
2021-01-04 15:29 ` [PATCH v9 12/17] PCI: cadence: Configure LM_EP_FUNC_CFG based on epc->function_num_map Kishon Vijay Abraham I
2021-01-04 15:29 ` [PATCH v9 13/17] PCI: endpoint: Add EP function driver to provide NTB functionality Kishon Vijay Abraham I
2021-01-19 19:04 ` Bjorn Helgaas
2021-01-04 15:29 ` [PATCH v9 14/17] PCI: Add TI J721E device to pci ids Kishon Vijay Abraham I
2021-01-04 15:29 ` [PATCH v9 15/17] NTB: Add support for EPF PCI-Express Non-Transparent Bridge Kishon Vijay Abraham I
2021-01-18 17:12 ` Dave Jiang
2021-01-04 15:29 ` [PATCH v9 16/17] Documentation: PCI: Add configfs binding documentation for pci-ntb endpoint function Kishon Vijay Abraham I
2021-01-04 15:29 ` [PATCH v9 17/17] Documentation: PCI: Add userguide for PCI endpoint NTB function Kishon Vijay Abraham I
2021-01-19 18:34 ` Bjorn Helgaas
2021-01-22 14:08 ` Kishon Vijay Abraham I
2021-01-04 15:46 ` [PATCH v9 00/17] Implement NTB Controller using multiple PCI EP Kishon Vijay Abraham I
2021-01-18 5:14 ` Kishon Vijay Abraham I
2021-01-19 11:29 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119183519.GA2496938@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=allenbh@gmail.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=dave.jiang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdmason@kudzu.us \
--cc=kishon@ti.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=tjoseph@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).