From: Leon Romanovsky <leon@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: free of node in pci_scan_device's error path
Date: Sun, 24 Jan 2021 07:39:12 +0200 [thread overview]
Message-ID: <20210124053912.GA4742@unreal> (raw)
In-Reply-To: <20210123005838.3623618-1-dmitry.baryshkov@linaro.org>
On Sat, Jan 23, 2021 at 03:58:38AM +0300, Dmitry Baryshkov wrote:
> In the pci_scan_device() if pci_setup_device() fails for any reason, the
> code will not release device's of_node by calling pci_release_of_node().
> Fix that by calling the release function.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Fixes: 98d9f30c820d ("pci/of: Match PCI devices to OF nodes dynamically")
Fixes should come before your SOB, otherwise many static checkers will
report the current format as an error.
Thanks
prev parent reply other threads:[~2021-01-24 6:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 0:58 [PATCH] PCI: free of node in pci_scan_device's error path Dmitry Baryshkov
2021-01-24 5:39 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210124053912.GA4742@unreal \
--to=leon@kernel.org \
--cc=bhelgaas@google.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).