From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23977C433DB for ; Tue, 2 Feb 2021 06:17:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBC2264EDD for ; Tue, 2 Feb 2021 06:17:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231941AbhBBGRL (ORCPT ); Tue, 2 Feb 2021 01:17:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231924AbhBBGRJ (ORCPT ); Tue, 2 Feb 2021 01:17:09 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDD3CC0613ED for ; Mon, 1 Feb 2021 22:16:28 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id s24so1608643pjp.5 for ; Mon, 01 Feb 2021 22:16:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1NqKt1tkYjXYw5uT6W0gag7j6UD0Pw2ioTo6s17oNpE=; b=LIQE6iXhoVslxswTP0KgBiXobDim0ju5ZYkrmyKvYra9JaoER+znAmc9qT9xTPVIt9 jtJp4IGHblx4gB7wk3KL0g+Hb00CnXsMXEYUJcWHtjBB8foOwO+AUaKNeRXK9ZgkhRKx unkdwcCqhuoaaet8S05RadBgyTo9LLCg4RKzfWTfjpFw0H97MwDGbtL4K8TPiIrR+CLV DwRwQ/IGJ8gY6RwwC4QvP+2Eo9r3HN+B83VS/PZdcxWUj5ka7LREzljL9mQeerH3xM4Z 9xY7VqEODF93PjT/9QkROmbj3BKowCGvzX+TVEKvk4DRJaXjYZyncefY2/3uwm/Blrhc kU9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1NqKt1tkYjXYw5uT6W0gag7j6UD0Pw2ioTo6s17oNpE=; b=MG6jftSkL2Bd6a6NIzlPsxAbRaIVY7zu0RrzuKONsjBcVCVsfDlYdTEUUPSIRFWlp8 e/DUaVf9mvvranyVdOYpVbFalB7WB6O5mHVHXMK8CvrbwXn4ZVtxMZu9UWRwLovzJkQS BGuSm6F2qa6odyihyNrClLg9Gzi5kjeAKYuV+0R8hGH9DDX8xFZ7O0b3eHlGEs3Kwqde P4buK86GaUGr4uqyv4dyGtW1RZvgWojS6ZNsIqyh5JyJQqWwyf95BzQZqy3Jjq3MuS/Z nJUexIOsYxqQ+Km2CPodp5wPOikgC87c7ICn489/BoUP01GNjj1ipZW/CCZObxF5b6at IeUQ== X-Gm-Message-State: AOAM533WDPy1uPV3a6ErihopDG8kwRwhaBWazy3Xv6XvEioXqts24Z8U FHCjUTtCRK5nHfjAq+QAsEnC X-Google-Smtp-Source: ABdhPJx0A/UAcWiA3V+ISiM2k6qA5tPlnvHP9HVWN/SYdIrEkyV65T+v0hqfxGwDjC/6oH+Cyvts7w== X-Received: by 2002:a17:903:1cc:b029:de:98bb:d46d with SMTP id e12-20020a17090301ccb02900de98bbd46dmr21069426plh.54.1612246588193; Mon, 01 Feb 2021 22:16:28 -0800 (PST) Received: from thinkpad ([2409:4072:6d83:1efe:9823:4cab:2941:306]) by smtp.gmail.com with ESMTPSA id l2sm1447547pju.25.2021.02.01.22.16.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 22:16:27 -0800 (PST) Date: Tue, 2 Feb 2021 11:46:19 +0530 From: Manivannan Sadhasivam To: Rob Herring Cc: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Arnd Bergmann , Greg Kroah-Hartman , Stanimir Varbanov , Lorenzo Pieralisi , Bjorn Helgaas , linux-arm-msm , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , PCI Subject: Re: [PATCH v2 5/5] arm64: dts: qcom: Add Bluetooth support on RB5 Message-ID: <20210202061619.GA13607@thinkpad> References: <20210128175225.3102958-1-dmitry.baryshkov@linaro.org> <20210128175225.3102958-6-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Jan 28, 2021 at 01:15:22PM -0600, Rob Herring wrote: > On Thu, Jan 28, 2021 at 11:52 AM Dmitry Baryshkov > wrote: > > > > From: Manivannan Sadhasivam > > > > Add Bluetooth support on RB5 using the onboard QCA6391 WLAN+BT chipset. > > > > Signed-off-by: Manivannan Sadhasivam > > [DB: added qca6391 power domain, removed s2f regulator] > > Signed-off-by: Dmitry Baryshkov > > --- > > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 29 ++++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > > index b39a9729395f..c65c13994a86 100644 > > --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > > +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > > @@ -19,6 +19,7 @@ / { > > compatible = "qcom,qrb5165-rb5", "qcom,sm8250"; > > > > aliases { > > + hsuart0 = &uart6; > > Serial devices should be 'serialN'. Don't add custom aliases. > Sorry, this is needed by the serial driver: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/serial/qcom_geni_serial.c#n1364 Thanks, Mani > > serial0 = &uart12; > > sdhc2 = &sdhc_2; > > BTW, this should be dropped too. > > > }; > > @@ -689,6 +690,26 @@ &pm8150_rtc { > > status = "okay"; > > }; > > > > +&qup_uart6_default { > > + ctsrx { > > + pins = "gpio16", "gpio19"; > > + drive-strength = <2>; > > + bias-disable; > > + }; > > + > > + rts { > > + pins = "gpio17"; > > + drive-strength = <2>; > > + bias-disable; > > + }; > > + > > + tx { > > + pins = "gpio18"; > > + drive-strength = <2>; > > + bias-pull-up; > > + }; > > +}; > > + > > &qupv3_id_0 { > > status = "okay"; > > }; > > @@ -1194,6 +1215,14 @@ wlan-en { > > }; > > }; > > > > +&uart6 { > > + status = "okay"; > > + bluetooth { > > + compatible = "qcom,qca6390-bt"; > > + power-domains = <&qca6391>; > > + }; > > +}; > > + > > &uart12 { > > status = "okay"; > > }; > > -- > > 2.29.2 > >