linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Niklas Schnelle <schnelle@linux.ibm.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-s390@vger.kernel.org,
	Peter Oberparleiter <oberpar@linux.ibm.com>,
	Viktor Mihajlovski <mihajlov@linux.ibm.com>
Subject: [RFC v2 0/1] s390/pci: expose UID checking state in sysfs
Date: Thu,  4 Feb 2021 10:43:52 +0100	[thread overview]
Message-ID: <20210204094353.63819-1-schnelle@linux.ibm.com> (raw)

Hi Bjorn,

this is a follow-up to my previous RFC of exposing our s390 specific UID
Checking attribute at /sys/bus/pci/zpci/unique_uids. As suggested by Greg
(thanks!) this version changes things to use named attributes directly without
resorting to any raw kobject handling, as a result the code moves to
drivers/pci/pci-sysfs.c with a CONFIG_S390 ifdef. Also I've changed the wording
to be more restrictive about what this attribute means. Instead of directly
calling out its current use to determine if UIDs are used as PCI domains it now
only explicitly claims that /sys/bus/pci/devices/<dev>/uid is guaranteed to be
a unique user-defined (in the zVM/KVM/LPAR configuration not Linux user-space)
identifier for the PCI function.

We've had some more internal discussion on this and are also considering to
instead put this attribute at /sys/firmware/zpci/unique_uids but as far as
I can see this strictly requires the use of raw kobject handling and loses us
the direct relation with PCI so I wanted to give this just one more shot and
get your opinion on it.

Thanks,
Niklas


Niklas Schnelle (1):
  PCI: Add s390 specific UID uniqueness attribute

 Documentation/ABI/testing/sysfs-bus-pci |  9 +++++++++
 drivers/pci/pci-sysfs.c                 | 21 +++++++++++++++++++++
 2 files changed, 30 insertions(+)

-- 
2.17.1


             reply	other threads:[~2021-02-04  9:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  9:43 Niklas Schnelle [this message]
2021-02-04  9:43 ` [RFC v2 1/1] PCI: Add s390 specific UID uniqueness attribute Niklas Schnelle
2021-02-04 10:40   ` Greg Kroah-Hartman
2021-02-04 12:02     ` Niklas Schnelle
2021-02-04 13:38       ` Greg Kroah-Hartman
2021-02-04 14:41         ` Niklas Schnelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210204094353.63819-1-schnelle@linux.ibm.com \
    --to=schnelle@linux.ibm.com \
    --cc=bhelgaas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mihajlov@linux.ibm.com \
    --cc=oberpar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).