From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Randy Dunlap <rdunlap@infradead.org>, kishon@ti.com
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH -next] PCI: endpoint: fix build error, EP NTB driver uses configfs
Date: Thu, 4 Feb 2021 09:58:15 +0000 [thread overview]
Message-ID: <20210204095815.GA26804@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20210202201255.26768-1-rdunlap@infradead.org>
On Tue, Feb 02, 2021 at 12:12:55PM -0800, Randy Dunlap wrote:
> The pci-epf-ntb driver uses configfs APIs, so it should depend on
> CONFIGFS_FS to prevent build errors.
>
> ld: drivers/pci/endpoint/functions/pci-epf-ntb.o: in function `epf_ntb_add_cfs':
> pci-epf-ntb.c:(.text+0x1b): undefined reference to `config_group_init_type_name'
>
> Fixes: 7dc64244f9e9 ("PCI: endpoint: Add EP function driver to provide NTB functionality")
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: linux-pci@vger.kernel.org
> ---
> You may switch to 'select CONFIG_FS_FS' if you feel strongly about it.
Kishon ?
Thanks,
Lorenzo
> drivers/pci/endpoint/functions/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210202.orig/drivers/pci/endpoint/functions/Kconfig
> +++ linux-next-20210202/drivers/pci/endpoint/functions/Kconfig
> @@ -16,6 +16,7 @@ config PCI_EPF_TEST
> config PCI_EPF_NTB
> tristate "PCI Endpoint NTB driver"
> depends on PCI_ENDPOINT
> + depends on CONFIGFS_FS
> help
> Select this configuration option to enable the NTB driver
> for PCI Endpoint. NTB driver implements NTB controller
next prev parent reply other threads:[~2021-02-04 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 20:12 [PATCH -next] PCI: endpoint: fix build error, EP NTB driver uses configfs Randy Dunlap
2021-02-04 9:58 ` Lorenzo Pieralisi [this message]
2021-02-04 13:45 ` Kishon Vijay Abraham I
2021-02-04 17:09 ` Lorenzo Pieralisi
2021-02-05 5:03 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204095815.GA26804@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).