linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI/ERR: Fix state assignment
@ 2021-02-10 15:16 Keith Busch
  2021-02-10 16:14 ` Krzysztof Wilczyński
  0 siblings, 1 reply; 3+ messages in thread
From: Keith Busch @ 2021-02-10 15:16 UTC (permalink / raw)
  To: linux-pci, Bjorn Helgaas; +Cc: Keith Busch

The state was intended to be assigned rather than compared for equality.

Link: https://lore.kernel.org/linux-pci/202102101255.HZtDITwe-lkp@intel.com/
Fixes: 8fae7d8809b815148 ("PCI/ERR: Simplify pci_dev_set_io_state()")
Cc: Bjorn Helgass <helgaas@kernel.org>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
 drivers/pci/pci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index db267120c962..1e4e4cb48bab 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -345,7 +345,7 @@ static inline bool pci_dev_set_io_state(struct pci_dev *dev,
 
 	/* Can always put a device in perm_failure state */
 	if (new == pci_channel_io_perm_failure) {
-		dev->error_state == pci_channel_io_perm_failure;
+		dev->error_state = pci_channel_io_perm_failure;
 		return true;
 	}
 
-- 
2.25.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI/ERR: Fix state assignment
  2021-02-10 15:16 [PATCH] PCI/ERR: Fix state assignment Keith Busch
@ 2021-02-10 16:14 ` Krzysztof Wilczyński
  2021-02-10 16:59   ` Keith Busch
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Wilczyński @ 2021-02-10 16:14 UTC (permalink / raw)
  To: Keith Busch; +Cc: linux-pci, Bjorn Helgaas

Hi Keith,

[...]
>  	if (new == pci_channel_io_perm_failure) {
> -		dev->error_state == pci_channel_io_perm_failure;
> +		dev->error_state = pci_channel_io_perm_failure;
[...]

Ouch!  Nice catch.

Reviewed-by: Krzysztof Wilczyński <kw@linux.com>

Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI/ERR: Fix state assignment
  2021-02-10 16:14 ` Krzysztof Wilczyński
@ 2021-02-10 16:59   ` Keith Busch
  0 siblings, 0 replies; 3+ messages in thread
From: Keith Busch @ 2021-02-10 16:59 UTC (permalink / raw)
  To: Krzysztof Wilczyński; +Cc: linux-pci, Bjorn Helgaas

On Wed, Feb 10, 2021 at 05:14:26PM +0100, Krzysztof Wilczyński wrote:
> Hi Keith,
> 
> [...]
> >  	if (new == pci_channel_io_perm_failure) {
> > -		dev->error_state == pci_channel_io_perm_failure;
> > +		dev->error_state = pci_channel_io_perm_failure;
> [...]
> 
> Ouch!  Nice catch.

Heh, the 0-day build actually caught this one, so credit to the bot! :)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-02-10 17:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10 15:16 [PATCH] PCI/ERR: Fix state assignment Keith Busch
2021-02-10 16:14 ` Krzysztof Wilczyński
2021-02-10 16:59   ` Keith Busch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).