From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E3EC433DB for ; Tue, 9 Mar 2021 15:22:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1BE465275 for ; Tue, 9 Mar 2021 15:22:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231909AbhCIPWG (ORCPT ); Tue, 9 Mar 2021 10:22:06 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:53654 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231843AbhCIPV5 (ORCPT ); Tue, 9 Mar 2021 10:21:57 -0500 Date: Tue, 9 Mar 2021 16:21:54 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1615303316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dMzJIAXAV30j1DWB/JqGaPTwHrsv+jgx0jyX1dMqhMo=; b=ftswzIWj+SpSqfoTdsjF9jYwsUZ7QmSJS28/2TmLeNwsNz3k9sItFtSmMQHJzTTAHn1l73 X+AI4oxoI9xuqHQn5N6yGS5zmQBFXR0sTTbBaSkyJmPokZkhKGw5Rt7yRIYgOKSlxAKO0/ iWLjf9J4+Z1WYG8e1cBqukW+PvN+5Ehe98iK5Rn4W18d+n8AQp/tUbMjdvpHpBfRWh+hv0 dTH35w1YOniiaqyYXdtLhDSVEwB9BzITsk5FUychB6d1PBB4HBn0l/ucowPnKkeX1cn/Qr OsWuvmgbW5tqyJ46C2kczn/yc1oKeJZzac9Ax/3fHVAWZ8+U6G4IkveXKBd7nA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1615303316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dMzJIAXAV30j1DWB/JqGaPTwHrsv+jgx0jyX1dMqhMo=; b=7I+TC8Pc4LH6B4D6vhEbJbVGv2HrVwmyRUmFwd62TcoO/FW4sNuDVvS4FldBwqa7cxztZ3 iHD0Tkwptxth9xAw== From: Sebastian Andrzej Siewior To: Thomas Gleixner Cc: LKML , Frederic Weisbecker , "Ahmed S. Darwish" , Peter Zijlstra , Denis Kirjanov , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, ath9k-devel@qca.qualcomm.com, Kalle Valo , linux-wireless@vger.kernel.org, Chas Williams <3chas3@gmail.com>, linux-atm-general@lists.sourceforge.net, "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, Stefan Richter , linux1394-devel@lists.sourceforge.net Subject: Re: [patch 07/14] tasklets: Prevent tasklet_unlock_spin_wait() deadlock on RT Message-ID: <20210309152154.jqi62ep2ndkpoikc@linutronix.de> References: <20210309084203.995862150@linutronix.de> <20210309084241.988908275@linutronix.de> <20210309150036.5rcecmmz2wbu4ypc@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210309150036.5rcecmmz2wbu4ypc@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 2021-03-09 16:00:37 [+0100], To Thomas Gleixner wrote: > diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h > index 07c7329d21aa7..1c14ccd351091 100644 > --- a/include/linux/interrupt.h > +++ b/include/linux/interrupt.h > @@ -663,15 +663,6 @@ static inline int tasklet_trylock(struct tasklet_struct *t) > void tasklet_unlock(struct tasklet_struct *t); > void tasklet_unlock_wait(struct tasklet_struct *t); > > -/* > - * Do not use in new code. Waiting for tasklets from atomic contexts is > - * error prone and should be avoided. > - */ > -static inline void tasklet_unlock_spin_wait(struct tasklet_struct *t) > -{ > - while (test_bit(TASKLET_STATE_RUN, &t->state)) > - cpu_relax(); > -} Look at that. The forward declaration for tasklet_unlock_spin_wait() should have remained. Sorry for that. Sebastian