From: "Pali Rohár" <email@example.com> To: Bjorn Helgaas <firstname.lastname@example.org> Cc: "Marek Behún" <email@example.com>, firstname.lastname@example.org, Rötti <email@example.com>, firstname.lastname@example.org, "Zachary Zhang" <email@example.com> Subject: Re: [PATCH] PCI: Add Max Payload Size quirk for ASMedia ASM1062 SATA controller Date: Fri, 19 Mar 2021 20:02:28 +0100 [thread overview] Message-ID: <20210319190228.xdejimfdpjch6de4@pali> (raw) In-Reply-To: <20210317230355.GA95738@bjorn-Precision-5520> On Wednesday 17 March 2021 18:03:55 Bjorn Helgaas wrote: > On Wed, Mar 17, 2021 at 11:55:44PM +0100, Pali Rohár wrote: > > On Wednesday 17 March 2021 17:45:49 Bjorn Helgaas wrote: > > > This quirk suggests that there's a hardware defect in the ASMedia > > > ASM1062. But if that's really the case, we should see reports on lots > > > of platforms, and I'm only aware of these two. > > > > Do you have platform which support MPS of 512 bytes? Because I have not > > seen any x86 / Intel PCIe controller with such support on ordinary > > laptop and desktop. > > > > These two (A3720 and CN9130) are the only which has support for it. > > > > Has somebody else PCIe controller which Root Bridge supports MPS of 512 > > bytes? > > > > Maybe they are in servers, but then such "cheap" SATA controllers are > > not used in servers. So this is probably reason why nobody else reported > > such issue. > > I have no idea. My laptop only supports 512 (except for an ASMedia > USB controller). If the device advertises it, I would expect the > vendor to test it. Obviously it still could be a device defect. They > should publish an erratum if that's the case so people know to avoid > it. So I would try to get ASMedia to say "no, that's tested and > should work" or "oh, sorry, here's an erratum and we'll fix it in the > next round." I doubt that ASMedia publish something... But has somebody contact to ASMedia? I can try it. Basically these ASMedia SATA controller chips are present on more "noname" mPCIe-form cards and I guess ASMedia is not going to support them. Note that we have also tested Marvell PCIe-based SATA controllers which support MPS of 512 bytes too and there were no problem with them on A3720 nor CN9130.
next prev parent reply other threads:[~2021-03-19 19:03 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-17 11:59 Marek Behún 2021-03-17 18:46 ` Pali Rohár 2021-03-17 22:45 ` Bjorn Helgaas 2021-03-17 22:55 ` Pali Rohár 2021-03-17 23:03 ` Bjorn Helgaas 2021-03-19 19:02 ` Pali Rohár [this message] 2021-03-21 15:09 ` Rötti 2021-05-30 10:21 ` Pali Rohár 2021-08-26 11:00 ` Rötti 2021-03-17 23:09 ` Marek Behún 2021-04-16 13:54 ` Marek Behún 2021-04-25 15:29 ` Pali Rohár 2021-05-11 16:16 ` Marek Behún 2021-05-28 0:12 ` Pali Rohár 2021-06-01 17:09 ` Bjorn Helgaas 2021-06-01 21:15 ` Bjorn Helgaas 2021-06-01 11:36 ` Krzysztof Wilczyński
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210319190228.xdejimfdpjch6de4@pali \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] PCI: Add Max Payload Size quirk for ASMedia ASM1062 SATA controller' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).