From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8E42C433DB for ; Fri, 26 Mar 2021 20:18:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A14E61A13 for ; Fri, 26 Mar 2021 20:18:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230224AbhCZUSH (ORCPT ); Fri, 26 Mar 2021 16:18:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:37166 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230134AbhCZURw (ORCPT ); Fri, 26 Mar 2021 16:17:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2450561A18; Fri, 26 Mar 2021 20:17:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616789872; bh=HQiYbloBWeueZbq2L4oIhpCdSmR81v4HPpPi6S55n34=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=ANchPUbA7/niZ+2pM4ATJhblFIlE8ITlpAvMJLR+NSAxfJASezVQ9ueEhWhaJElvb 5Fjusoq4cJ0G/sOxwXl0fz5HbIhwNBasdrdYjbUx3UmyCIR9b3qNbDa58OMuixoW2X tAqhmk5N+YeYehwzOTjnh11PdSoJieSF11ZManBgDB4SgRa29rCFAORH3ljc5PkIbB ZKTGa6IrzdubbAH9NINQB1/6Ykjvb9+oSblL3CEV1aTv9MoLtZ90DjyEpoe9aJtQp1 GrFCofGtIWioYjjG8FMi4rBUtVqEWTLQVYfcrq2YwQgiawMoXxMqoMzs6DEKEsmYUh V+3mns8AoL8vQ== Date: Fri, 26 Mar 2021 15:17:50 -0500 From: Bjorn Helgaas To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Rob Herring , Mark Brown , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Lorenzo Pieralisi , Bjorn Helgaas , Florian Fainelli , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v3 3/6] PCI: brcmstb: Do not turn off regulators if EP can wake up Message-ID: <20210326201750.GA905944@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210326191906.43567-4-jim2101024@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Mar 26, 2021 at 03:19:01PM -0400, Jim Quinlan wrote: > If any downstream device may wake up during S2/S3 suspend, we do not want > to turn off its power when suspending. > > Signed-off-by: Jim Quinlan > --- > drivers/pci/controller/pcie-brcmstb.c | 58 +++++++++++++++++++++++---- > 1 file changed, 51 insertions(+), 7 deletions(-) > +enum { > + TURN_OFF, /* Turn egulators off, unless an EP is wakeup-capable */ > + TURN_OFF_ALWAYS, /* Turn Regulators off, no exceptions */ > + TURN_ON, /* Turn regulators on, unless pcie->ep_wakeup_capable */ s/egulators/regulators/ s/Regulators/regulators/