From: "Pali Rohár" <pali@kernel.org>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: "Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Kalle Valo" <kvalo@codeaurora.org>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Marek Behún" <kabel@kernel.org>,
vtolkm@gmail.com, "Rob Herring" <robh@kernel.org>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
linux-pci@vger.kernel.org, ath10k@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Disallow retraining link for Atheros QCA98xx chips on non-Gen1 PCIe bridges
Date: Sat, 27 Mar 2021 18:33:27 +0100 [thread overview]
Message-ID: <20210327173327.tfn4mjq3cvrq33qu@pali> (raw)
In-Reply-To: <20210327154213.571aa263@dellmb.labs.office.nic.cz>
On Saturday 27 March 2021 15:42:13 Marek Behún wrote:
> On Sat, 27 Mar 2021 14:29:59 +0100
> Pali Rohár <pali@kernel.org> wrote:
>
> > I can change this to 'if (!ret)' if needed, no problem.
> >
> > I use 'if (!val)' mostly for boolean and pointer variables. If
> > variable can contain more integer values then I lot of times I use
> > '=='.
>
> Comparing integer varibales with explicit literals is sensible, but
> if a function returning integer returns 0 on success and negative value
> on error, Linux kernel has a tradition of using just
> if (!ret)
> or
> if (ret)
>
> Marek
Ok, I will change it.
next prev parent reply other threads:[~2021-03-27 17:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 12:43 [PATCH] PCI: Disallow retraining link for Atheros QCA98xx chips on non-Gen1 PCIe bridges Pali Rohár
2021-03-26 18:13 ` Toke Høiland-Jørgensen
2021-03-27 0:14 ` Krzysztof Wilczyński
2021-03-27 13:29 ` Pali Rohár
2021-03-27 14:42 ` Marek Behún
2021-03-27 17:33 ` Pali Rohár [this message]
2021-04-27 10:55 ` [PATCH v2] PCI: Disallow retraining link for Atheros " Pali Rohár
2021-04-30 11:41 ` Pali Rohár
2021-05-05 16:33 ` [PATCH v3] " Pali Rohár
2021-05-11 20:39 ` Pali Rohár
2021-05-28 0:08 ` Pali Rohár
2021-06-01 11:28 ` Krzysztof Wilczyński
2021-06-01 20:05 ` Bjorn Helgaas
2021-06-01 21:18 ` Pali Rohár
2021-06-02 0:00 ` Bjorn Helgaas
2021-06-02 12:08 ` Pali Rohár
2021-06-02 15:55 ` Bjorn Helgaas
2021-06-02 19:03 ` Pali Rohár
2021-06-16 21:38 ` Bjorn Helgaas
2021-06-21 14:28 ` Pali Rohár
2021-06-25 20:19 ` Bjorn Helgaas
2021-06-26 14:38 ` Pali Rohár
2021-06-21 14:39 ` Pali Rohár
2021-10-05 19:43 ` Jannis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210327173327.tfn4mjq3cvrq33qu@pali \
--to=pali@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=bhelgaas@google.com \
--cc=ilias.apalodimas@linaro.org \
--cc=kabel@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=toke@redhat.com \
--cc=vtolkm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).