From: Willy Tarreau <w@1wt.eu>
To: Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
Cc: linux-doc@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
Derek Kiernan <derek.kiernan@xilinx.com>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Bjorn Helgaas <bhelgaas@google.com>,
Krzysztof Wilczynski <kw@linux.com>
Subject: Re: [PATCH v8 5/5] FIX driver
Date: Mon, 29 Mar 2021 12:03:03 +0200 [thread overview]
Message-ID: <20210329100303.GA21530@1wt.eu> (raw)
In-Reply-To: <20405596c759cf6cabca83e7a9cd90113fbea557.1617011282.git.gustavo.pimentel@synopsys.com>
On Mon, Mar 29, 2021 at 11:51:38AM +0200, Gustavo Pimentel wrote:
> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Please make an effort, this is in no way an acceptable commit description
for a patch. The subject is already extremely vague "FIX driver" with no
context at all, and there is no description of the intent here. What is
someone supposed to think about the risk of keeping or reverting it if a
bisect section would end on this one ?
Thanks,
Willy
next prev parent reply other threads:[~2021-03-29 10:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 9:51 [PATCH v8 0/5] misc: Add Add Synopsys DesignWare xData IP driver Gustavo Pimentel
2021-03-29 9:51 ` [PATCH v8 1/5] misc: " Gustavo Pimentel
2021-03-29 9:51 ` [PATCH v8 2/5] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver Gustavo Pimentel
2021-03-29 9:51 ` [PATCH v8 3/5] MAINTAINERS: Add Synopsys xData IP driver maintainer Gustavo Pimentel
2021-03-29 9:51 ` [PATCH v8 4/5] docs: ABI: Add sysfs documentation interface of dw-xdata-pcie driver Gustavo Pimentel
2021-03-29 9:51 ` [PATCH v8 5/5] FIX driver Gustavo Pimentel
2021-03-29 10:03 ` Willy Tarreau [this message]
2021-03-29 10:09 ` Gustavo Pimentel
2021-03-29 10:06 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210329100303.GA21530@1wt.eu \
--to=w@1wt.eu \
--cc=Gustavo.Pimentel@synopsys.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=derek.kiernan@xilinx.com \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=kw@linux.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).