From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE2A6C433E0 for ; Mon, 29 Mar 2021 10:04:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9429561554 for ; Mon, 29 Mar 2021 10:04:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231873AbhC2KDj (ORCPT ); Mon, 29 Mar 2021 06:03:39 -0400 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:51067 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231959AbhC2KDU (ORCPT ); Mon, 29 Mar 2021 06:03:20 -0400 Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 12TA335d021555; Mon, 29 Mar 2021 12:03:03 +0200 Date: Mon, 29 Mar 2021 12:03:03 +0200 From: Willy Tarreau To: Gustavo Pimentel Cc: linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Andrew Morton , Greg Kroah-Hartman , Jonathan Corbet , Bjorn Helgaas , Krzysztof Wilczynski Subject: Re: [PATCH v8 5/5] FIX driver Message-ID: <20210329100303.GA21530@1wt.eu> References: <20405596c759cf6cabca83e7a9cd90113fbea557.1617011282.git.gustavo.pimentel@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20405596c759cf6cabca83e7a9cd90113fbea557.1617011282.git.gustavo.pimentel@synopsys.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Mar 29, 2021 at 11:51:38AM +0200, Gustavo Pimentel wrote: > Signed-off-by: Gustavo Pimentel Please make an effort, this is in no way an acceptable commit description for a patch. The subject is already extremely vague "FIX driver" with no context at all, and there is no description of the intent here. What is someone supposed to think about the risk of keeping or reverting it if a bisect section would end on this one ? Thanks, Willy