From: ErKun Yang <yangerkun@huawei.com>
To: <toan@os.amperecomputing.com>, <lorenzo.pieralisi@arm.com>,
<robh@kernel.org>, <bhelgaas@google.com>
Cc: <linux-pci@vger.kernel.org>, <yangerkun@huawei.com>,
<yukuai3@huawei.com>
Subject: [PATCH v2] PCI: xgene-msi: Remove redundant dev_err call in xgene_msi_probe()
Date: Thu, 8 Apr 2021 21:27:51 +0800 [thread overview]
Message-ID: <20210408132751.1198171-1-yangerkun@huawei.com> (raw)
devm_ioremap_resource() internally calls __devm_ioremap_resource() which
is where error checking and handling is actually having place. So the
dev_err in xgene_msi_probe() seems redundant and remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
Signed-off-by: ErKun Yang <yangerkun@huawei.com>
---
drivers/pci/controller/pci-xgene-msi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c
index 1c34c897a7e2..369b50f626fd 100644
--- a/drivers/pci/controller/pci-xgene-msi.c
+++ b/drivers/pci/controller/pci-xgene-msi.c
@@ -451,7 +451,6 @@ static int xgene_msi_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
xgene_msi->msi_regs = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(xgene_msi->msi_regs)) {
- dev_err(&pdev->dev, "no reg space\n");
rc = PTR_ERR(xgene_msi->msi_regs);
goto error;
}
--
2.25.4
next reply other threads:[~2021-04-08 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 13:27 ErKun Yang [this message]
2021-04-08 13:21 ` [PATCH v2] PCI: xgene-msi: Remove redundant dev_err call in xgene_msi_probe() ErKun Yang
2021-05-27 13:33 ` yangerkun
2021-08-05 11:12 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408132751.1198171-1-yangerkun@huawei.com \
--to=yangerkun@huawei.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=toan@os.amperecomputing.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).