From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D7B6C43461 for ; Thu, 29 Apr 2021 15:15:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C0366145A for ; Thu, 29 Apr 2021 15:15:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233486AbhD2PQM (ORCPT ); Thu, 29 Apr 2021 11:16:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:35596 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232989AbhD2PQM (ORCPT ); Thu, 29 Apr 2021 11:16:12 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D4C3F6144B; Thu, 29 Apr 2021 15:15:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619709324; bh=BlAMIRtj2IZcp3ctO0A7trOlyHNIVXGiVatXmNlOtaw=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Tw9xxmLej/iCGcwMhxSO0GKEfaH0cNxBr32lYkOPpREnevCLPgML+fQZxu1mJUy3H Gy1jZkYjfKpqU/AR+WYe2wcB1K5u98IztUAgR7FumJWPRhrii7d/e3US5utNwv1Rf/ 3eruYEuAywtxkmMcR37KbN5HXs7fjnaYfysJoKlv2ES+YaF6McR5JTaNBInUhpIU3H EYDzVlNVF9R1DqvzULmQ1a6BqxyNg1r+wjGjvIhmjvp1RSwMFfWZ/m93cmC+tiFYlu lyG3h3E0b5yMporFkhj9CJakxkq26BllyAYfyMkzobO4HjlX32fe1d5+pYZMNa5JR4 wImFV9Lcieqpw== Date: Thu, 29 Apr 2021 10:15:22 -0500 From: Bjorn Helgaas To: Lorenzo Pieralisi Cc: Greentime Hu , paul.walmsley@sifive.com, hes@sifive.com, erik.danie@sifive.com, zong.li@sifive.com, bhelgaas@google.com, robh+dt@kernel.org, aou@eecs.berkeley.edu, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, alex.dewar90@gmail.com, khilman@baylibre.com, hayashi.kunihiko@socionext.com, vidyas@nvidia.com, jh80.chung@samsung.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v5 5/6] PCI: fu740: Add SiFive FU740 PCIe host controller driver Message-ID: <20210429151522.GA495642@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210429145954.GA29122@lpieralisi> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Apr 29, 2021 at 03:59:54PM +0100, Lorenzo Pieralisi wrote: > On Wed, Apr 28, 2021 at 02:47:13PM -0500, Bjorn Helgaas wrote: > > On Tue, Apr 06, 2021 at 05:26:33PM +0800, Greentime Hu wrote: > > > From: Paul Walmsley > > > > > > Add driver for the SiFive FU740 PCIe host controller. > > > This controller is based on the DesignWare PCIe core. > > > > > > Signed-off-by: Paul Walmsley > > > Co-developed-by: Henry Styles > > > Signed-off-by: Henry Styles > > > Co-developed-by: Erik Danie > > > Signed-off-by: Erik Danie > > > Co-developed-by: Greentime Hu > > > Signed-off-by: Greentime Hu > > > > Tripped over these errors while build testing with the .config below. > > Sorry about that - the kbot did not managed to test it. Is it a > randconfig ? I think we should ask the kbuild bot guys to add it, > I think it can be done on a per-repo basis. I don't know enough about the bot. The lkp@intel.com reports I get include allyesconfig for x86_64; not sure why that wouldn't catch this. > Waiting for a fix asap - I can move/rebase some commits if the fix > takes time. If it's feasible you could just move the FU740 stuff to a different branch so we can be sure to include the other dwc stuff. Same for brcmstb. Oh, and Colin just posted a NULL pointer check that could be squashed into the new mediatek-gen3 driver. Bjorn