From: Bjorn Helgaas <email@example.com>
To: Konstantin Kharlamov <firstname.lastname@example.org>
"Rafael J. Wysocki" <email@example.com>,
Andreas Noever <firstname.lastname@example.org>,
email@example.com, Lukas Wunner <firstname.lastname@example.org>
Subject: Re: [PATCH] PCI: don't power-off apple thunderbolt controller on s2idle
Date: Fri, 7 May 2021 08:07:24 -0500 [thread overview]
Message-ID: <20210507130724.GA1499364@bjorn-Precision-5520> (raw)
On Fri, May 07, 2021 at 12:32:20PM +0300, Konstantin Kharlamov wrote:
> On Thu, 2021-05-06 at 16:48 -0500, Bjorn Helgaas wrote:
> > [+cc Rafael, Andreas, linux-pm]
> > On Thu, May 06, 2021 at 08:38:20PM +0300, Konstantin Kharlamov wrote:
> > > On Macbook 2013 resuming from s2idle results in external monitor no
> > > longer being detected, and dmesg having errors like:
> > >
> > > pcieport 0000:06:00.0: can't change power state from D3hot to D0 (config
> > > space inaccessible)
> > >
> > > and a stacktrace. The reason turned out that the hw that the quirk
> > > powers off does not get powered on back on resume.
> > quirk_apple_poweroff_thunderbolt() was added in 2014 by 1df5172c5c25
> > ("PCI: Suspend/resume quirks for Apple thunderbolt"). It claims
> > "power is automatically restored before resume," so there must be
> > something special about s2idle that prevents the power-on.
> > IIUC this change will reduce the s2idle power savings. I would feel
> > better about this if we understood what the difference was.
> > > Thus, add a check for s2idle to the quirk, and do nothing if the suspend
> > > mode is s2idle.
> > Obviously the *hardware* hasn't changed since 1df5172c5c25. Is s2idle
> > something that wasn't tested back then, or is this problem connected
> > to an s2idle change since then? Can we identify a commit that
> > introduced this problem? That would help with backporting or stable
> > tags.
> > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=212767
> > Thanks for this! Would you mind attaching the output of
> > "sudo lspci -vvv"? If you attach any other dmesg, could you
> > use "dmesg --color=never" so the log doesn't include all the
> > escape characters?
> Thank you! So, just to be clear: in lieu of Lukas Wunner's reply, do
> you still want `lspci` and `dmesg` outputs, or are you okay with the
> information Lukas provided?
Yes, please attach at least lspci output. It helps understand the
topology and may be useful in the future. I wish we had a similar
bugzilla with more information about the original 1df5172c5c25.
> And while on it, an unrelated question to you as a maintainer: I
> never contributed to the kernel before: in case you are okay with
> the patch, what happens now that I got R-b, should I resend a v2 of
> it with the R-b added?
You don't need to resend a patch if the only change is to add
reviewed-by, acked-by, or similar tags.
next prev parent reply other threads:[~2021-05-07 13:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 17:38 [PATCH] PCI: don't power-off apple thunderbolt controller on s2idle Konstantin Kharlamov
2021-05-06 21:48 ` Bjorn Helgaas
2021-05-06 22:07 ` Lukas Wunner
2021-05-07 9:51 ` Rafael J. Wysocki
2021-05-08 8:48 ` Lukas Wunner
2021-05-07 13:30 ` Bjorn Helgaas
2021-05-07 14:08 ` Konstantin Kharlamov
2021-05-12 20:36 ` Konstantin Kharlamov
2021-05-17 19:51 ` PING " Konstantin Kharlamov
2021-05-19 17:28 ` Bjorn Helgaas
2021-05-19 19:12 ` Rafael J. Wysocki
2021-05-19 19:48 ` Bjorn Helgaas
2021-05-20 11:27 ` Rafael J. Wysocki
2021-05-20 11:54 ` Rafael J. Wysocki
2021-05-20 19:49 ` Bjorn Helgaas
2021-05-20 23:28 ` Konstantin Kharlamov
2021-05-24 6:59 ` Konstantin Kharlamov
2021-05-20 23:55 ` [PATCH v2] PCI: don't call firmware hooks on suspend unless it's fw-controlled Konstantin Kharlamov
2021-05-28 7:39 ` PING: " Konstantin Kharlamov
2021-06-03 8:36 ` PING: " Konstantin Kharlamov
2021-06-03 17:46 ` Bjorn Helgaas
2021-06-04 8:30 ` Konstantin Kharlamov
2021-05-21 9:47 ` [PATCH] PCI: don't power-off apple thunderbolt controller on s2idle Rafael J. Wysocki
2021-05-07 15:02 ` Rafael J. Wysocki
2021-05-08 8:20 ` Lukas Wunner
2021-05-07 9:32 ` Konstantin Kharlamov
2021-05-07 13:07 ` Bjorn Helgaas [this message]
2021-05-07 13:48 ` Konstantin Kharlamov
2021-05-20 11:58 ` Rafael J. Wysocki
2021-06-07 23:17 ` Bjorn Helgaas
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).