Re: [PATCH v6 15/16] drm/amd/display: Remove superflous drm_mode_config_cleanup

From: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
To: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	linux-pci@vger.kernel.org, ckoenig.leichtzumerken@gmail.com,
	daniel.vetter@ffwll.ch, Harry.Wentland@amd.com,
	gregkh@linuxfoundation.org, Felix.Kuehling@amd.com,
	ppaalanen@gmail.com, helgaas@kernel.org,
	Alexander.Deucher@amd.com
Subject: Re: [PATCH v6 15/16] drm/amd/display: Remove superflous drm_mode_config_cleanup
Date: Mon, 10 May 2021 17:38:45 -0400	[thread overview]
Message-ID: <20210510213845.jrxss62zisqyjeq6@outlook.office365.com> (raw)
In-Reply-To: <20210510163625.407105-16-andrey.grodzovsky@amd.com>

[-- Attachment #1: Type: text/plain, Size: 1526 bytes --]

lgtm,

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

On 05/10, Andrey Grodzovsky wrote:
> It's already being released by DRM core through devm
> 
> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 6c2c6a51ce6c..9728a0158bcb 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -3757,7 +3757,6 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)
>  
>  static void amdgpu_dm_destroy_drm_device(struct amdgpu_display_manager *dm)
>  {
> -	drm_mode_config_cleanup(dm->ddev);
>  	drm_atomic_private_obj_fini(&dm->atomic_obj);
>  	return;
>  }
> -- 
> 2.25.1
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7CRodrigo.Siqueira%40amd.com%7Cd7ebdc33a79d49d6560308d913d1e32c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637562614440095736%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=OtEAqSIaLB6CgKhLQGhIQc2A%2B6lprqGB31yqQts6OVc%3D&amp;reserved=0

-- 
Rodrigo Siqueira
https://siqueira.tech

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]