From: Bjorn Helgaas <helgaas@kernel.org>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: linux-pci@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Jingoo Han <jingoohan1@gmail.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Subject: Re: [PATCH 0/5] PCI: dwc: pci-dra7xx: miscellaneous improvements
Date: Mon, 17 May 2021 11:36:23 -0500 [thread overview]
Message-ID: <20210517163623.GA21579@bjorn-Precision-5520> (raw)
In-Reply-To: <20210517154122.430544-1-luca@lucaceresoli.net>
On Mon, May 17, 2021 at 05:41:17PM +0200, Luca Ceresoli wrote:
> This is an series of mixed improvements to the DRA7 PCI controller driver:
> allow building as a loadabel module, allow to get and enable a clock and a
> small cleanup.
>
> Luca
>
> Luca Ceresoli (5):
> PCI: dwc: export more symbols to allow modular drivers
> PCI: dwc: pci-dra7xx: make it a kernel module
> PCI: dwc: pci-dra7xx: allow to build as a loadable module
> PCI: dwc: pci-dra7xx: remove unused include
> PCI: dwc: pci-dra7xx: get an optional clock
This driver has a poor record of subject lines:
PCI: pci-dra7xx: Prepare for deferred probe with module_platform_driver
PCI: dwc: Move dw_pcie_setup_rc() to DWC common code
PCI: dwc/dra7xx: Use the common MSI irq_chip
PCI: dwc: pci-dra7xx: Fix runtime PM imbalance on error
The "PCI: dwc:" ones are fine -- they apply to the shared dwc core,
not specifically to dra7xx.
The driver-specific ones:
PCI: pci-dra7xx:
PCI: dwc/dra7xx:
PCI: dwc: pci-dra7xx:
are redundant and waste space. There's no need to mention "dwc" for
dra7xx-specific things, and no need to mention "PCI" twice.
We should use the "PCI: dra7xx:" prefix for things specific to this
driver.
The rest of the subject line should start with a capital letter. The
subject line should contain specific information when practical. For
example,
PCI: dwc: Export dw_pcie_link_up(), dw_pcie_ep_reset_bar() for modular drivers
PCI: dra7xx: Allow building as module
PCI: dra7xx: Remove unused linux/init.h include
PCI: dra7xx: Get optional external clock
I would squash 2/5 and 3/5, similar to a98d2187efd9 ("PCI: meson:
Build as module by default") and 526a76991b7b ("PCI: aardvark:
Implement driver 'remove' function and allow to build it as module").
> drivers/pci/controller/dwc/Kconfig | 6 +++---
> drivers/pci/controller/dwc/pci-dra7xx.c | 21 +++++++++++++++++--
> .../pci/controller/dwc/pcie-designware-ep.c | 1 +
> drivers/pci/controller/dwc/pcie-designware.c | 1 +
> 4 files changed, 24 insertions(+), 5 deletions(-)
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-05-17 16:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 15:41 [PATCH 0/5] PCI: dwc: pci-dra7xx: miscellaneous improvements Luca Ceresoli
2021-05-17 15:41 ` [PATCH 1/5] PCI: dwc: export more symbols to allow modular drivers Luca Ceresoli
2021-05-17 15:41 ` [PATCH 2/5] PCI: dwc: pci-dra7xx: make it a kernel module Luca Ceresoli
2021-05-18 18:55 ` Rob Herring
2021-05-18 21:39 ` Luca Ceresoli
2021-05-17 15:41 ` [PATCH 3/5] PCI: dwc: pci-dra7xx: allow to build as a loadable module Luca Ceresoli
2021-05-17 15:41 ` [PATCH 4/5] PCI: dwc: pci-dra7xx: remove unused include Luca Ceresoli
2021-05-17 15:41 ` [PATCH 5/5] PCI: dwc: pci-dra7xx: get an optional clock Luca Ceresoli
2021-05-17 16:36 ` Bjorn Helgaas [this message]
2021-05-18 17:06 ` [PATCH 0/5] PCI: dwc: pci-dra7xx: miscellaneous improvements Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517163623.GA21579@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=luca@lucaceresoli.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).