From: Bjorn Helgaas <helgaas@kernel.org>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: bhelgaas@google.com, maz@kernel.org, lorenzo.pieralisi@arm.com,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/MSI: Fix MSIs for generic hosts that use device-tree's "msi-map"
Date: Tue, 25 May 2021 18:40:09 -0500 [thread overview]
Message-ID: <20210525234009.GA1242540@bjorn-Precision-5520> (raw)
In-Reply-To: <20210510173129.750496-1-jean-philippe@linaro.org>
On Mon, May 10, 2021 at 07:31:30PM +0200, Jean-Philippe Brucker wrote:
> Since commit 9ec37efb8783 ("PCI/MSI: Make pci_host_common_probe()
> declare its reliance on MSI domains"), platforms that rely on the
> "msi-map" device-tree property don't get MSIs anymore.
>
> On the Arm Fast Model for example [1], the host bridge doesn't have a
> "msi-parent" property since it doesn't itself generate MSIs, and so
> doesn't get a MSI domain. It has an "msi-map" property instead to
> describe MSI controllers of child devices. As a result, due to the new
> msi_domain check in pci_register_host_bridge(), the whole bus gets
> PCI_BUS_FLAGS_NO_MSI.
>
> Check whether the root complex has an "msi-map" property before giving
> up on MSIs.
>
> [1] arch/arm64/boot/dts/arm/fvp-base-revc.dts
>
> Fixes: 9ec37efb8783 ("PCI/MSI: Make pci_host_common_probe() declare its reliance on MSI domains")
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Applied to for-linus for v5.13, since we merged 9ec37efb8783 for
v5.13-rc1. Thanks!
> ---
> include/linux/pci.h | 2 ++
> drivers/pci/of.c | 7 +++++++
> drivers/pci/probe.c | 3 ++-
> 3 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index c20211e59a57..24306504226a 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -2344,6 +2344,7 @@ int pci_vpd_find_info_keyword(const u8 *buf, unsigned int off,
> struct device_node;
> struct irq_domain;
> struct irq_domain *pci_host_bridge_of_msi_domain(struct pci_bus *bus);
> +bool pci_host_of_has_msi_map(struct device *dev);
>
> /* Arch may override this (weak) */
> struct device_node *pcibios_get_phb_of_node(struct pci_bus *bus);
> @@ -2351,6 +2352,7 @@ struct device_node *pcibios_get_phb_of_node(struct pci_bus *bus);
> #else /* CONFIG_OF */
> static inline struct irq_domain *
> pci_host_bridge_of_msi_domain(struct pci_bus *bus) { return NULL; }
> +static inline bool pci_host_of_has_msi_map(struct device *dev) { return false; }
> #endif /* CONFIG_OF */
>
> static inline struct device_node *
> diff --git a/drivers/pci/of.c b/drivers/pci/of.c
> index da5b414d585a..85dcb7097da4 100644
> --- a/drivers/pci/of.c
> +++ b/drivers/pci/of.c
> @@ -103,6 +103,13 @@ struct irq_domain *pci_host_bridge_of_msi_domain(struct pci_bus *bus)
> #endif
> }
>
> +bool pci_host_of_has_msi_map(struct device *dev)
> +{
> + if (dev && dev->of_node)
> + return of_get_property(dev->of_node, "msi-map", NULL);
> + return false;
> +}
> +
> static inline int __of_pci_pci_compare(struct device_node *node,
> unsigned int data)
> {
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index 3a62d09b8869..275204646c68 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -925,7 +925,8 @@ static int pci_register_host_bridge(struct pci_host_bridge *bridge)
> device_enable_async_suspend(bus->bridge);
> pci_set_bus_of_node(bus);
> pci_set_bus_msi_domain(bus);
> - if (bridge->msi_domain && !dev_get_msi_domain(&bus->dev))
> + if (bridge->msi_domain && !dev_get_msi_domain(&bus->dev) &&
> + !pci_host_of_has_msi_map(parent))
> bus->bus_flags |= PCI_BUS_FLAGS_NO_MSI;
>
> if (!parent)
> --
> 2.31.1
>
prev parent reply other threads:[~2021-05-25 23:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 17:31 [PATCH] PCI/MSI: Fix MSIs for generic hosts that use device-tree's "msi-map" Jean-Philippe Brucker
2021-05-10 18:23 ` Marc Zyngier
2021-05-11 14:12 ` Jean-Philippe Brucker
2021-05-18 8:48 ` Marc Zyngier
2021-05-25 23:40 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210525234009.GA1242540@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=jean-philippe@linaro.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=maz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).