From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BEEEC47088 for ; Wed, 26 May 2021 12:59:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FACE613D4 for ; Wed, 26 May 2021 12:59:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232236AbhEZNBR (ORCPT ); Wed, 26 May 2021 09:01:17 -0400 Received: from verein.lst.de ([213.95.11.211]:34829 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232103AbhEZNBR (ORCPT ); Wed, 26 May 2021 09:01:17 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 0E26967373; Wed, 26 May 2021 14:59:43 +0200 (CEST) Date: Wed, 26 May 2021 14:59:42 +0200 From: Christoph Hellwig To: Kai-Heng Feng Cc: Keith Busch , Koba Ko , Christoph Hellwig , Jens Axboe , Sagi Grimberg , linux-nvme , Linux Kernel Mailing List , Henrik Juul Hansen , Bjorn Helgaas , Linux PCI Subject: Re: [PATCH] nvme-pci: Avoid to go into d3cold if device can't use npss. Message-ID: <20210526125942.GA25080@lst.de> References: <20210520033315.490584-1-koba.ko@canonical.com> <20210525074426.GA14916@lst.de> <20210526024934.GB3704949@dhcp-10-100-145-180.wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, May 26, 2021 at 08:11:41PM +0800, Kai-Heng Feng wrote: > On Wed, May 26, 2021 at 10:49 AM Keith Busch wrote: > > > > On Wed, May 26, 2021 at 10:02:27AM +0800, Koba Ko wrote: > > > On Tue, May 25, 2021 at 3:44 PM Christoph Hellwig wrote: > > > > > > > > On Thu, May 20, 2021 at 11:33:15AM +0800, Koba Ko wrote: > > > > > After resume, host can't change power state of the closed controller > > > > > from D3cold to D0. > > > > > > > > Why? > > > As per Kai-Heng said, it's a regression introduced by commit > > > b97120b15ebd ("nvme-pci: > > > use simple suspend when a HMB is enabled"). The affected NVMe is using HMB. > > > > That really doesn't add up. The mentioned commit restores the driver > > behavior for HMB drives that existed prior to d916b1be94b6d from kernel > > 5.3. Is that NVMe device broken in pre-5.3 kernels, too? > > Quite likely. The system in question is a late 2020 Ice Lake laptop, > so it was released after 5.3 kernel. This is just a mess. We had to disable the sensible power state based suspend on these systems because Intel broke it by just cutting the power off. And now the shutdown based one doesn't work either because it can't handle d3cold. Someone we need to stop Intel and the integrators from doing stupid things, and I'm not sure how. But degrading all systems even more is just a bad idea, so I fear we'll need a quirk again. Can you figure out by switching the cards if this is the fault of the platform or the nvme device? > > Kai-Heng ---end quoted text---