From: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
To: Rob Herring <robh+dt@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
PCI <linux-pci@vger.kernel.org>,
Punit Agrawal <punit1.agrawal@toshiba.co.jp>,
yuji2.ishikawa@toshiba.co.jp,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] dt-bindings: pci: Add DT binding for Toshiba Visconti PCIe controller
Date: Thu, 27 May 2021 09:22:51 +0900 [thread overview]
Message-ID: <20210527002251.zyrpmy4u2asdn7bo@toshiba.co.jp> (raw)
In-Reply-To: <CAL_JsqKE0o9dUmJxgSg3_e_s7Dh3Vrjb60=u+xRd7erCVnFHWQ@mail.gmail.com>
On Wed, May 26, 2021 at 11:33:35AM -0500, Rob Herring wrote:
> On Mon, May 24, 2021 at 1:30 AM Nobuhiro Iwamatsu
> <nobuhiro1.iwamatsu@toshiba.co.jp> wrote:
> >
> > This commit adds the Device Tree binding documentation that allows
> > to describe the PCIe controller found in Toshiba Visconti SoCs.
> >
> > v1 -> v2:
> > - Remove white space.
> > - Drop num-viewport and bus-range from required.
> > - Drop status line from example.
> > - Drop bus-range from required.
> > - Removed lines defined in pci-bus.yaml from required.
> >
> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> > ---
> > .../bindings/pci/toshiba,visconti-pcie.yaml | 110 ++++++++++++++++++
> > 1 file changed, 110 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml
>
> Please resend to DT list. Otherwise, automated checks don't run
OK, I will resent to DT list.
> (though I'm sure you ran 'make dt_binding_check' already, right?).
Yes, I ran it enerytime.
> >
> > diff --git a/Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml b/Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml
> > new file mode 100644
> > index 000000000000..d47a4a3c49e3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml
> > @@ -0,0 +1,110 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pci/toshiba,visconti-pcie.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Toshiba Visconti5 SoC PCIe Host Controller Device Tree Bindings
> > +
> > +maintainers:
> > + - Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> > +
> > +description: |+
> > + Toshiba Visconti5 SoC PCIe host controller is based on the Synopsys DesignWare PCIe IP.
> > +
> > +allOf:
> > + - $ref: /schemas/pci/pci-bus.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: toshiba,visconti-pcie
> > +
> > + reg:
> > + items:
> > + - description: Data Bus Interface (DBI) registers.
> > + - description: PCIe configuration space region.
> > + - description: Visconti specific additional registers.
> > + - description: Visconti specific SMU registers
> > + - description: Visconti specific memory protection unit registers (MPU)
> > +
> > + reg-names:
> > + items:
> > + - const: dbi
> > + - const: config
> > + - const: ulreg
> > + - const: smu
> > + - const: mpu
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + items:
> > + - description: PCIe reference clock
> > + - description: PCIe system clock
> > + - description: Auxiliary clock
> > +
> > + clock-names:
> > + items:
> > + - const: pcie_refclk
>
> Just 'refclk'. Though 'clk' is redundant too. I'd go with 'ref',
> 'aux', and 'core'.
>
Ok, I will update.
> > + - const: sysclk
> > + - const: auxclk
> > +
> > + num-lanes:
> > + const: 2
> > +
> > +required:
> > + - reg
> > + - reg-names
> > + - interrupts
> > + - "#interrupt-cells"
> > + - interrupt-map
> > + - interrupt-map-mask
> > + - num-lanes
> > + - clocks
> > + - clock-names
> > + - max-link-speed
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > + soc {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > +
> > + pcie: pcie@28400000 {
> > + compatible = "toshiba,visconti-pcie";
> > + reg = <0x0 0x28400000 0x0 0x00400000>,
> > + <0x0 0x70000000 0x0 0x10000000>,
> > + <0x0 0x28050000 0x0 0x00010000>,
> > + <0x0 0x24200000 0x0 0x00002000>,
> > + <0x0 0x24162000 0x0 0x00001000>;
> > + reg-names = "dbi", "config", "ulreg", "smu", "mpu";
> > + device_type = "pci";
> > + bus-range = <0x00 0xff>;
> > + num-lanes = <2>;
> > + num-viewport = <8>;
> > +
> > + #address-cells = <3>;
> > + #size-cells = <2>;
> > + #interrupt-cells = <1>;
> > + ranges = <0x81000000 0 0x40000000 0 0x40000000 0 0x00010000>,
> > + <0x82000000 0 0x50000000 0 0x50000000 0 0x20000000>;
> > + interrupts = <GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-names = "intr";
> > + interrupt-map-mask = <0 0 0 7>;
> > + interrupt-map =
> > + <0 0 0 1 &gic GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH
> > + 0 0 0 2 &gic GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH
> > + 0 0 0 3 &gic GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH
> > + 0 0 0 4 &gic GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&extclk100mhz>, <&clk600mhz>, <&clk25mhz>;
> > + clock-names = "pcie_refclk", "sysclk", "auxclk";
> > + max-link-speed = <2>;
> > + };
> > + };
> > +...
> > --
> > 2.31.1
> >
>
Best regards,
Nobuhiro
next prev parent reply other threads:[~2021-05-27 0:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 6:30 [PATCH v3 0/3] Visconti: Add Toshiba Visconti PCIe host controller driver Nobuhiro Iwamatsu
2021-05-24 6:30 ` [PATCH v3 1/3] dt-bindings: pci: Add DT binding for Toshiba Visconti PCIe controller Nobuhiro Iwamatsu
2021-05-26 16:33 ` Rob Herring
2021-05-27 0:22 ` Nobuhiro Iwamatsu [this message]
2021-05-24 6:30 ` [PATCH v3 2/3] PCI: Visconti: Add Toshiba Visconti PCIe host controller driver Nobuhiro Iwamatsu
2021-05-24 11:10 ` Krzysztof Wilczyński
2021-05-28 0:19 ` Nobuhiro Iwamatsu
2021-05-24 18:58 ` Bjorn Helgaas
2021-06-16 1:31 ` Nobuhiro Iwamatsu
2021-06-16 16:32 ` Rob Herring
2021-06-27 0:00 ` Nobuhiro Iwamatsu
2021-05-24 6:30 ` [PATCH v3 3/3] MAINTAINERS: Add entries for Toshiba Visconti PCIe controller Nobuhiro Iwamatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527002251.zyrpmy4u2asdn7bo@toshiba.co.jp \
--to=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=punit1.agrawal@toshiba.co.jp \
--cc=robh+dt@kernel.org \
--cc=yuji2.ishikawa@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).