From: "Krzysztof Wilczyński" <kw@linux.com>
To: Joe Perches <joe@perches.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Logan Gunthorpe <logang@deltatee.com>,
Oliver O'Halloran <oohall@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Tyrel Datwyler <tyreld@linux.ibm.com>,
Russell Currey <ruscur@russell.cc>,
Kurt Schwemmer <kurt.schwemmer@microsemi.com>,
Vidya Sagar <vidyas@nvidia.com>,
Xiongfeng Wang <wangxiongfeng2@huawei.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v5 2/5] PCI/sysfs: Use return value from dsm_label_utf16s_to_utf8s() directly
Date: Thu, 27 May 2021 23:34:04 +0200 [thread overview]
Message-ID: <20210527213404.GA37266@rocinante.localdomain> (raw)
In-Reply-To: <b6f3d949ca5c1723001494a371d1a74ef0ff72ed.camel@perches.com>
Hi Joe,
[...]
> > -static void dsm_label_utf16s_to_utf8s(union acpi_object *obj, char *buf)
> > +static int dsm_label_utf16s_to_utf8s(union acpi_object *obj, char *buf)
> > {
> > int len;
> > +
> > len = utf16s_to_utf8s((const wchar_t *)obj->buffer.pointer,
> > obj->buffer.length,
> > UTF16_LITTLE_ENDIAN,
> > buf, PAGE_SIZE);
>
> This should be PAGE_SIZE - 1 no?
>
> > buf[len] = '\n';
> > +
> > + return len;
>
> return len + 1 ?
Good catch!
I left the original code as-is, and this old latent bug would remain
there. I am glad you had a moment to review this new version. Thank
you!
I will send v6 later and include this as separate patch per Bjorn's
request.
Krzysztof
next prev parent reply other threads:[~2021-05-27 21:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 20:16 [PATCH v5 1/5] PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in "show" functions Krzysztof Wilczyński
2021-05-27 20:16 ` [PATCH v5 2/5] PCI/sysfs: Use return value from dsm_label_utf16s_to_utf8s() directly Krzysztof Wilczyński
2021-05-27 20:23 ` Joe Perches
2021-05-27 21:34 ` Krzysztof Wilczyński [this message]
2021-05-27 20:16 ` [PATCH v5 3/5] PCI/sysfs: Fix trailing newline handling of resource_alignment_param Krzysztof Wilczyński
2021-05-27 20:16 ` [PATCH v5 4/5] PCI/sysfs: Add missing trailing newline to devspec_show() Krzysztof Wilczyński
2021-05-27 20:16 ` [PATCH v5 5/5] PCI/sysfs: Only show value when driver_override is not NULL Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527213404.GA37266@rocinante.localdomain \
--to=kw@linux.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=joe@perches.com \
--cc=kurt.schwemmer@microsemi.com \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=mpe@ellerman.id.au \
--cc=oohall@gmail.com \
--cc=paulus@samba.org \
--cc=ruscur@russell.cc \
--cc=tyreld@linux.ibm.com \
--cc=vidyas@nvidia.com \
--cc=wangxiongfeng2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).