[PATCH v2 0/4] PCI: dwc: pci-dra7xx: miscellaneous improvements

[PATCH v2 0/4] PCI: dwc: pci-dra7xx: miscellaneous improvements

[Luca Ceresoli]

This is an series of mixed improvements to the DRA7 PCI controller driver:
allow building as a loadabel module, allow to get and enable a clock and a
small cleanup.

Luca

Luca Ceresoli (4):
  PCI: dwc: Export more symbols to allow modular drivers
  PCI: dra7xx: Make it a kernel module
  PCI: dra7xx: Remove unused include
  PCI: dra7xx: Get an optional clock

 drivers/pci/controller/dwc/Kconfig            |  6 ++---
 drivers/pci/controller/dwc/pci-dra7xx.c       | 22 +++++++++++++++++--
 .../pci/controller/dwc/pcie-designware-ep.c   |  1 +
 drivers/pci/controller/dwc/pcie-designware.c  |  1 +
 4 files changed, 25 insertions(+), 5 deletions(-)

-- 
2.25.1

[PATCH v2 1/4] PCI: dwc: Export more symbols to allow modular drivers

[Luca Ceresoli]

These symbols are used by the pci-dra7xx driver. Export them to allow
building pci-dra7xx as a module.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

---

Changes v1 -> v2:
 - Update commit subject as suggested by Bjorn
---
 drivers/pci/controller/dwc/pcie-designware-ep.c | 1 +
 drivers/pci/controller/dwc/pcie-designware.c    | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
index 8d028a88b375..f2692a138216 100644
--- a/drivers/pci/controller/dwc/pcie-designware-ep.c
+++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
@@ -83,6 +83,7 @@ void dw_pcie_ep_reset_bar(struct dw_pcie *pci, enum pci_barno bar)
 	for (func_no = 0; func_no < funcs; func_no++)
 		__dw_pcie_ep_reset_bar(pci, func_no, bar, 0);
 }
+EXPORT_SYMBOL_GPL(dw_pcie_ep_reset_bar);
 
 static u8 __dw_pcie_ep_find_next_cap(struct dw_pcie_ep *ep, u8 func_no,
 		u8 cap_ptr, u8 cap)
diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
index a945f0c0e73d..850b4533f4ef 100644
--- a/drivers/pci/controller/dwc/pcie-designware.c
+++ b/drivers/pci/controller/dwc/pcie-designware.c
@@ -538,6 +538,7 @@ int dw_pcie_link_up(struct dw_pcie *pci)
 	return ((val & PCIE_PORT_DEBUG1_LINK_UP) &&
 		(!(val & PCIE_PORT_DEBUG1_LINK_IN_TRAINING)));
 }
+EXPORT_SYMBOL_GPL(dw_pcie_link_up);
 
 void dw_pcie_upconfig_setup(struct dw_pcie *pci)
 {
-- 
2.25.1

[PATCH v2 2/4] PCI: dra7xx: Make it a kernel module

[Luca Ceresoli]

Enable building the driver as a loadable kernel module.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

---

Changes v1 -> v2:
 - Update commit subject (Bjorn)
 - Update commit message body (Rob)
 - Add MODULE_DEVICE_TABLE() for autoloading (Rob)
---
 drivers/pci/controller/dwc/Kconfig      | 6 +++---
 drivers/pci/controller/dwc/pci-dra7xx.c | 8 +++++++-
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index 423d35872ce4..775ad590966e 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -17,10 +17,10 @@ config PCIE_DW_EP
 	select PCIE_DW
 
 config PCI_DRA7XX
-	bool
+	tristate
 
 config PCI_DRA7XX_HOST
-	bool "TI DRA7xx PCIe controller Host Mode"
+	tristate "TI DRA7xx PCIe controller Host Mode"
 	depends on SOC_DRA7XX || COMPILE_TEST
 	depends on PCI_MSI_IRQ_DOMAIN
 	depends on OF && HAS_IOMEM && TI_PIPE3
@@ -36,7 +36,7 @@ config PCI_DRA7XX_HOST
 	  This uses the DesignWare core.
 
 config PCI_DRA7XX_EP
-	bool "TI DRA7xx PCIe controller Endpoint Mode"
+	tristate "TI DRA7xx PCIe controller Endpoint Mode"
 	depends on SOC_DRA7XX || COMPILE_TEST
 	depends on PCI_ENDPOINT
 	depends on OF && HAS_IOMEM && TI_PIPE3
diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
index 6457695df00c..9fcadd7dd943 100644
--- a/drivers/pci/controller/dwc/pci-dra7xx.c
+++ b/drivers/pci/controller/dwc/pci-dra7xx.c
@@ -15,6 +15,7 @@
 #include <linux/irqdomain.h>
 #include <linux/kernel.h>
 #include <linux/init.h>
+#include <linux/module.h>
 #include <linux/of_device.h>
 #include <linux/of_gpio.h>
 #include <linux/of_pci.h>
@@ -611,6 +612,7 @@ static const struct of_device_id of_dra7xx_pcie_match[] = {
 	},
 	{},
 };
+MODULE_DEVICE_TABLE(of, of_dra7xx_pcie_match);
 
 /*
  * dra7xx_pcie_unaligned_memaccess: workaround for AM572x/AM571x Errata i870
@@ -949,4 +951,8 @@ static struct platform_driver dra7xx_pcie_driver = {
 	},
 	.shutdown = dra7xx_pcie_shutdown,
 };
-builtin_platform_driver(dra7xx_pcie_driver);
+module_platform_driver(dra7xx_pcie_driver);
+
+MODULE_AUTHOR("Kishon Vijay Abraham I <kishon@ti.com>");
+MODULE_DESCRIPTION("PCIe controller driver for TI DRA7xx SoCs");
+MODULE_LICENSE("GPL v2");
-- 
2.25.1

[PATCH v2 3/4] PCI: dra7xx: Remove unused include

[Luca Ceresoli]

Unused since commit e259c2926c01 ("PCI: pci-dra7xx: Prepare for deferred
probe with module_platform_driver").

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

---

Changes v1 -> v2:
 - Update commit subject as suggested by Bjorn
---
 drivers/pci/controller/dwc/pci-dra7xx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
index 9fcadd7dd943..a8daa356f7e6 100644
--- a/drivers/pci/controller/dwc/pci-dra7xx.c
+++ b/drivers/pci/controller/dwc/pci-dra7xx.c
@@ -14,7 +14,6 @@
 #include <linux/irq.h>
 #include <linux/irqdomain.h>
 #include <linux/kernel.h>
-#include <linux/init.h>
 #include <linux/module.h>
 #include <linux/of_device.h>
 #include <linux/of_gpio.h>
-- 
2.25.1

[PATCH v2 4/4] PCI: dra7xx: Get an optional clock

[Luca Ceresoli]

If the clock is provided externally we need to make sure it is enabled
before starting PCI scan.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

---

Changes v1 -> v2:
 - Update commit subject as suggested by Bjorn
---
 drivers/pci/controller/dwc/pci-dra7xx.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
index a8daa356f7e6..11f392b7a9a2 100644
--- a/drivers/pci/controller/dwc/pci-dra7xx.c
+++ b/drivers/pci/controller/dwc/pci-dra7xx.c
@@ -7,6 +7,7 @@
  * Authors: Kishon Vijay Abraham I <kishon@ti.com>
  */
 
+#include <linux/clk.h>
 #include <linux/delay.h>
 #include <linux/device.h>
 #include <linux/err.h>
@@ -90,6 +91,7 @@ struct dra7xx_pcie {
 	int			phy_count;	/* DT phy-names count */
 	struct phy		**phy;
 	struct irq_domain	*irq_domain;
+	struct clk              *clk;
 	enum dw_pcie_device_mode mode;
 };
 
@@ -745,6 +747,15 @@ static int dra7xx_pcie_probe(struct platform_device *pdev)
 	if (!link)
 		return -ENOMEM;
 
+	dra7xx->clk = devm_clk_get_optional(dev, NULL);
+	if (IS_ERR(dra7xx->clk))
+		return dev_err_probe(dev, PTR_ERR(dra7xx->clk),
+				     "clock request failed");
+
+	ret = clk_prepare_enable(dra7xx->clk);
+	if (ret)
+		return ret;
+
 	for (i = 0; i < phy_count; i++) {
 		snprintf(name, sizeof(name), "pcie-phy%d", i);
 		phy[i] = devm_phy_get(dev, name);
@@ -932,6 +943,8 @@ static void dra7xx_pcie_shutdown(struct platform_device *pdev)
 
 	pm_runtime_disable(dev);
 	dra7xx_pcie_disable_phy(dra7xx);
+
+	clk_disable_unprepare(dra7xx->clk);
 }
 
 static const struct dev_pm_ops dra7xx_pcie_pm_ops = {
-- 
2.25.1

Re: [PATCH v2 0/4] PCI: dwc: pci-dra7xx: miscellaneous improvements

[Lorenzo Pieralisi]

On Mon, May 31, 2021 at 10:59:30AM +0200, Luca Ceresoli wrote:
> This is an series of mixed improvements to the DRA7 PCI controller driver:
> allow building as a loadabel module, allow to get and enable a clock and a
> small cleanup.
> 
> Luca
> 
> Luca Ceresoli (4):
>   PCI: dwc: Export more symbols to allow modular drivers
>   PCI: dra7xx: Make it a kernel module
>   PCI: dra7xx: Remove unused include
>   PCI: dra7xx: Get an optional clock
> 
>  drivers/pci/controller/dwc/Kconfig            |  6 ++---
>  drivers/pci/controller/dwc/pci-dra7xx.c       | 22 +++++++++++++++++--
>  .../pci/controller/dwc/pcie-designware-ep.c   |  1 +
>  drivers/pci/controller/dwc/pcie-designware.c  |  1 +
>  4 files changed, 25 insertions(+), 5 deletions(-)

Hi Kishon,

I'd need your ACK to proceed with this series that looks like it
is ready to go, please let me know.

Thanks,
Lorenzo

Re: [PATCH v2 0/4] PCI: dwc: pci-dra7xx: miscellaneous improvements

[Lorenzo Pieralisi]

On Mon, Jun 21, 2021 at 03:41:09PM +0100, Lorenzo Pieralisi wrote:
> On Mon, May 31, 2021 at 10:59:30AM +0200, Luca Ceresoli wrote:
> > This is an series of mixed improvements to the DRA7 PCI controller driver:
> > allow building as a loadabel module, allow to get and enable a clock and a
> > small cleanup.
> > 
> > Luca
> > 
> > Luca Ceresoli (4):
> >   PCI: dwc: Export more symbols to allow modular drivers
> >   PCI: dra7xx: Make it a kernel module
> >   PCI: dra7xx: Remove unused include
> >   PCI: dra7xx: Get an optional clock
> > 
> >  drivers/pci/controller/dwc/Kconfig            |  6 ++---
> >  drivers/pci/controller/dwc/pci-dra7xx.c       | 22 +++++++++++++++++--
> >  .../pci/controller/dwc/pcie-designware-ep.c   |  1 +
> >  drivers/pci/controller/dwc/pcie-designware.c  |  1 +
> >  4 files changed, 25 insertions(+), 5 deletions(-)
> 
> Hi Kishon,
> 
> I'd need your ACK to proceed with this series that looks like it
> is ready to go, please let me know.

Still need it - please let me know.

Lorenzo

Re: [PATCH v2 0/4] PCI: dwc: pci-dra7xx: miscellaneous improvements

[Luca Ceresoli]

Hi Lorenzo, Kishon,

On 13/08/21 17:53, Lorenzo Pieralisi wrote:
> On Mon, Jun 21, 2021 at 03:41:09PM +0100, Lorenzo Pieralisi wrote:
>> On Mon, May 31, 2021 at 10:59:30AM +0200, Luca Ceresoli wrote:
>>> This is an series of mixed improvements to the DRA7 PCI controller driver:
>>> allow building as a loadabel module, allow to get and enable a clock and a
>>> small cleanup.
>>>
>>> Luca
>>>
>>> Luca Ceresoli (4):
>>>   PCI: dwc: Export more symbols to allow modular drivers
>>>   PCI: dra7xx: Make it a kernel module
>>>   PCI: dra7xx: Remove unused include
>>>   PCI: dra7xx: Get an optional clock
>>>
>>>  drivers/pci/controller/dwc/Kconfig            |  6 ++---
>>>  drivers/pci/controller/dwc/pci-dra7xx.c       | 22 +++++++++++++++++--
>>>  .../pci/controller/dwc/pcie-designware-ep.c   |  1 +
>>>  drivers/pci/controller/dwc/pcie-designware.c  |  1 +
>>>  4 files changed, 25 insertions(+), 5 deletions(-)
>>
>> Hi Kishon,
>>
>> I'd need your ACK to proceed with this series that looks like it
>> is ready to go, please let me know.
> 
> Still need it - please let me know.
> 
> Lorenzo

Should I resend the series?

BTW it still applies cleanly on both the pci next branch and on mainline
master.

-- 
Luca

Re: [PATCH v2 0/4] PCI: dwc: pci-dra7xx: miscellaneous improvements

[Kishon Vijay Abraham I]

On 20/09/21 2:33 am, Luca Ceresoli wrote:
> Hi Lorenzo, Kishon,
> 
> On 13/08/21 17:53, Lorenzo Pieralisi wrote:
>> On Mon, Jun 21, 2021 at 03:41:09PM +0100, Lorenzo Pieralisi wrote:
>>> On Mon, May 31, 2021 at 10:59:30AM +0200, Luca Ceresoli wrote:
>>>> This is an series of mixed improvements to the DRA7 PCI controller driver:
>>>> allow building as a loadabel module, allow to get and enable a clock and a
>>>> small cleanup.
>>>>
>>>> Luca
>>>>
>>>> Luca Ceresoli (4):
>>>>   PCI: dwc: Export more symbols to allow modular drivers
>>>>   PCI: dra7xx: Make it a kernel module
>>>>   PCI: dra7xx: Remove unused include
>>>>   PCI: dra7xx: Get an optional clock
>>>>
>>>>  drivers/pci/controller/dwc/Kconfig            |  6 ++---
>>>>  drivers/pci/controller/dwc/pci-dra7xx.c       | 22 +++++++++++++++++--
>>>>  .../pci/controller/dwc/pcie-designware-ep.c   |  1 +
>>>>  drivers/pci/controller/dwc/pcie-designware.c  |  1 +
>>>>  4 files changed, 25 insertions(+), 5 deletions(-)
>>>
>>> Hi Kishon,
>>>
>>> I'd need your ACK to proceed with this series that looks like it
>>> is ready to go, please let me know.
>>
>> Still need it - please let me know.
>>
>> Lorenzo
> 
> Should I resend the series?
> 
> BTW it still applies cleanly on both the pci next branch and on mainline
> master.

For the series
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>

Re: [PATCH v2 0/4] PCI: dwc: pci-dra7xx: miscellaneous improvements

[Lorenzo Pieralisi]

On Sun, Sep 19, 2021 at 11:03:00PM +0200, Luca Ceresoli wrote:
> Hi Lorenzo, Kishon,
> 
> On 13/08/21 17:53, Lorenzo Pieralisi wrote:
> > On Mon, Jun 21, 2021 at 03:41:09PM +0100, Lorenzo Pieralisi wrote:
> >> On Mon, May 31, 2021 at 10:59:30AM +0200, Luca Ceresoli wrote:
> >>> This is an series of mixed improvements to the DRA7 PCI controller driver:
> >>> allow building as a loadabel module, allow to get and enable a clock and a
> >>> small cleanup.
> >>>
> >>> Luca
> >>>
> >>> Luca Ceresoli (4):
> >>>   PCI: dwc: Export more symbols to allow modular drivers
> >>>   PCI: dra7xx: Make it a kernel module
> >>>   PCI: dra7xx: Remove unused include
> >>>   PCI: dra7xx: Get an optional clock
> >>>
> >>>  drivers/pci/controller/dwc/Kconfig            |  6 ++---
> >>>  drivers/pci/controller/dwc/pci-dra7xx.c       | 22 +++++++++++++++++--
> >>>  .../pci/controller/dwc/pcie-designware-ep.c   |  1 +
> >>>  drivers/pci/controller/dwc/pcie-designware.c  |  1 +
> >>>  4 files changed, 25 insertions(+), 5 deletions(-)
> >>
> >> Hi Kishon,
> >>
> >> I'd need your ACK to proceed with this series that looks like it
> >> is ready to go, please let me know.
> > 
> > Still need it - please let me know.
> > 
> > Lorenzo
> 
> Should I resend the series?
> 
> BTW it still applies cleanly on both the pci next branch and on mainline
> master.

Kishon, please consider ACKing or otherwise comment on this series
to make some progress.

Thanks,
Lorenzo

Re: [PATCH v2 0/4] PCI: dwc: pci-dra7xx: miscellaneous improvements

[Kishon Vijay Abraham I]

Hi Lorenzo,

On 28/09/21 3:00 pm, Lorenzo Pieralisi wrote:
> On Sun, Sep 19, 2021 at 11:03:00PM +0200, Luca Ceresoli wrote:
>> Hi Lorenzo, Kishon,
>>
>> On 13/08/21 17:53, Lorenzo Pieralisi wrote:
>>> On Mon, Jun 21, 2021 at 03:41:09PM +0100, Lorenzo Pieralisi wrote:
>>>> On Mon, May 31, 2021 at 10:59:30AM +0200, Luca Ceresoli wrote:
>>>>> This is an series of mixed improvements to the DRA7 PCI controller driver:
>>>>> allow building as a loadabel module, allow to get and enable a clock and a
>>>>> small cleanup.
>>>>>
>>>>> Luca
>>>>>
>>>>> Luca Ceresoli (4):
>>>>>   PCI: dwc: Export more symbols to allow modular drivers
>>>>>   PCI: dra7xx: Make it a kernel module
>>>>>   PCI: dra7xx: Remove unused include
>>>>>   PCI: dra7xx: Get an optional clock
>>>>>
>>>>>  drivers/pci/controller/dwc/Kconfig            |  6 ++---
>>>>>  drivers/pci/controller/dwc/pci-dra7xx.c       | 22 +++++++++++++++++--
>>>>>  .../pci/controller/dwc/pcie-designware-ep.c   |  1 +
>>>>>  drivers/pci/controller/dwc/pcie-designware.c  |  1 +
>>>>>  4 files changed, 25 insertions(+), 5 deletions(-)
>>>>
>>>> Hi Kishon,
>>>>
>>>> I'd need your ACK to proceed with this series that looks like it
>>>> is ready to go, please let me know.
>>>
>>> Still need it - please let me know.
>>>
>>> Lorenzo
>>
>> Should I resend the series?
>>
>> BTW it still applies cleanly on both the pci next branch and on mainline
>> master.
> 
> Kishon, please consider ACKing or otherwise comment on this series
> to make some progress.

I had already ACKed this series
https://lore.kernel.org/all/598ee439-6882-5021-1351-f403e762430f@ti.com/

Anyways I'm adding it here again:
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>

Thank You,
Kishon
> 
> Thanks,
> Lorenzo
> 

Re: [PATCH v2 0/4] PCI: dwc: pci-dra7xx: miscellaneous improvements

[Lorenzo Pieralisi]

On Mon, 31 May 2021 10:59:30 +0200, Luca Ceresoli wrote:
> This is an series of mixed improvements to the DRA7 PCI controller driver:
> allow building as a loadabel module, allow to get and enable a clock and a
> small cleanup.
> 
> Luca
> 
> Luca Ceresoli (4):
>   PCI: dwc: Export more symbols to allow modular drivers
>   PCI: dra7xx: Make it a kernel module
>   PCI: dra7xx: Remove unused include
>   PCI: dra7xx: Get an optional clock
> 
> [...]

Applied to pci/dwc, thanks!

[1/4] PCI: dwc: Export more symbols to allow modular drivers
      https://git.kernel.org/lpieralisi/pci/c/3a7fb86758
[2/4] PCI: dra7xx: Make it a kernel module
      https://git.kernel.org/lpieralisi/pci/c/3b868d150e
[3/4] PCI: dra7xx: Remove unused include
      https://git.kernel.org/lpieralisi/pci/c/b9a6943dc8
[4/4] PCI: dra7xx: Get an optional clock
      https://git.kernel.org/lpieralisi/pci/c/5af9405397

Thanks,
Lorenzo