From: "Pali Rohár" <pali@kernel.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Sergio Paracuellos <sergio.paracuellos@gmail.com>,
lorenzo.pieralisi@arm.com, Bjorn Helgaas <helgaas@kernel.org>,
"open list:MIPS" <linux-mips@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
John Crispin <john@phrozen.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
linux-staging@lists.linux.dev,
Greg KH <gregkh@linuxfoundation.org>, NeilBrown <neil@brown.name>,
Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 0/4] MIPS: ralink: pci: driver for Pcie controller in MT7621 SoCs
Date: Mon, 31 May 2021 15:18:45 +0200 [thread overview]
Message-ID: <20210531131845.ookvz7njj6yrkaeh@pali> (raw)
In-Reply-To: <20210521102338.GA6989@alpha.franken.de>
On Friday 21 May 2021 12:23:38 Thomas Bogendoerfer wrote:
> On Wed, May 19, 2021 at 11:18:36PM +0200, Sergio Paracuellos wrote:
> > On Wed, May 19, 2021 at 10:36 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> > > But most of the similar drivers are in drivers/pci/controller/, where
> > > I think it's easier to keep them up to date with changes in the PCI
> > > core. Have you considered putting this one there?
> >
> > Most pci drivers in 'arch/mips/pci' are still using PCI_LEGACY stuff.
> > In contrast mt7621-pci is using current pci generic apis but even most
> > of the code is generic enough, there is one remaining thing which
> > depends on mips architecture which is the iocu region configuration
> > which must be done in the driver itself. This is the only reason to
> > move this driver into 'arch/mips/pci' instead of
> > 'drivers/pci/controller/'. So... I am all ears to listen to
> > suggestions for the proper place for this driver. Thomas, do you have
> > any thoughts on this?
>
> I tried to put a pci-xtalk driver into drivers/pci/controller, but
> Lorenzo didn't want it there for being MIPS and not DT based. So this
> one is DT based, but still MIPS. I'm perfectly fine putting this
> driver into drivers/pci/controller/
In my personal opinion this driver could go into drivers/pci/controller/
next prev parent reply other threads:[~2021-05-31 13:21 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 12:40 [PATCH 0/4] MIPS: ralink: pci: driver for Pcie controller in MT7621 SoCs Sergio Paracuellos
2021-05-15 12:40 ` [PATCH 1/4] dt-bindings: mt7621-pci: PCIe binding documentation for " Sergio Paracuellos
2021-05-31 11:45 ` Sergio Paracuellos
2021-06-04 19:35 ` Rob Herring
2021-06-04 21:32 ` Sergio Paracuellos
2021-06-05 15:06 ` Sergio Paracuellos
2021-05-15 12:40 ` [PATCH 2/4] MIPS: pci: Add driver for MT7621 PCIe controller Sergio Paracuellos
2021-05-31 13:14 ` Pali Rohár
2021-05-31 13:39 ` Sergio Paracuellos
2021-05-31 13:50 ` Pali Rohár
2021-05-31 14:19 ` Sergio Paracuellos
2021-06-02 12:16 ` Sergio Paracuellos
2021-06-02 12:23 ` Pali Rohár
2021-06-02 12:43 ` Sergio Paracuellos
2021-06-04 16:55 ` Pali Rohár
2021-06-04 18:44 ` Sergio Paracuellos
2021-06-04 23:07 ` Pali Rohár
2021-06-05 5:13 ` Sergio Paracuellos
2021-06-04 18:49 ` Rob Herring
2021-06-04 22:58 ` Pali Rohár
2021-06-05 5:11 ` Sergio Paracuellos
2021-06-04 19:30 ` Rob Herring
2021-06-04 22:25 ` Sergio Paracuellos
2021-06-07 6:45 ` Sergio Paracuellos
2021-06-04 19:49 ` Bjorn Helgaas
2021-06-04 21:19 ` Sergio Paracuellos
2021-05-15 12:40 ` [PATCH 3/4] staging: mt7621-pci: remove driver from staging Sergio Paracuellos
2021-06-04 13:08 ` Greg KH
2021-05-15 12:40 ` [PATCH 4/4] MAINTAINERS: add myself as maintainer of the MT7621 PCI controller driver Sergio Paracuellos
2021-05-19 20:36 ` [PATCH 0/4] MIPS: ralink: pci: driver for Pcie controller in MT7621 SoCs Bjorn Helgaas
2021-05-19 21:18 ` Sergio Paracuellos
2021-05-21 10:23 ` Thomas Bogendoerfer
2021-05-31 13:18 ` Pali Rohár [this message]
2021-06-04 19:43 ` Bjorn Helgaas
2021-06-04 21:15 ` Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210531131845.ookvz7njj6yrkaeh@pali \
--to=pali@kernel.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=ilya.lipnitskiy@gmail.com \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=neil@brown.name \
--cc=robh+dt@kernel.org \
--cc=sergio.paracuellos@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).