From: Pavel Machek <firstname.lastname@example.org>
To: stuart hayes <email@example.com>
Cc: Randy Dunlap <firstname.lastname@example.org>,
Bjorn Helgaas <email@example.com>,
firstname.lastname@example.org, Keith Busch <email@example.com>,
Subject: Re: [PATCH v2] Add support for PCIe SSD status LED management
Date: Thu, 3 Jun 2021 00:40:59 +0200 [thread overview]
Message-ID: <20210602224059.GA19673@duo.ucw.cz> (raw)
[-- Attachment #1: Type: text/plain, Size: 1712 bytes --]
> > > This would cause the system to somehow show the user that that this drive
> > > (or drive slot) is the one that it wants a person to be able to physically
> > > locate (possibly by flashing a blue LED on/near the drive), and also that
> > > the drive is OK. It would presumably do that by lighting the LEDs on/near
> > > the drive with certain colors and/or flashing patterns, though it could, in
> > > theory, put "OK" in an LCD on the drive slot. How the states are displayed
> > > to the user is beyond the scope of the specs.
> > >
> > > (The _DSM and NPEM specs provide for a way to control status LEDs on a drive
> > > or drive slot. Typically drives will have 2 or 3 LEDs that are illuminated
> > > in different colors or flashing patterns to indicate various states (like
> > > those listed in IBPI / SFF-8489), though the _DSM / NPEM specs do not
> > > specify how the states are displayed.)
> > Well, LED subsystem expects to know how many LEDs are there and what
> > the LEDs are, and expects individual control over them.
> > "2 or 3 LEDs with unknown patterns", or LCD display is outside of scope
> > of LED subsystem, so this should be independend.
> Yes... I had originally submitted this without using the LED subsystem, and
> Greg K-H said I had to (see
> https://www.spinics.net/lists/linux-pci/msg102013.html). Here's the
> relevant bit.
> So I'm not sure what to do.
Explain to Greg that you don't know how particular system implements
the indication. It can be small display, 2 LEDs, 3 LEDs, etc... LED
subsystem expects direct LED control.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2021-06-02 22:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 20:38 [PATCH v2] Add support for PCIe SSD status LED management Stuart Hayes
2021-06-01 21:20 ` Randy Dunlap
2021-06-01 22:38 ` Pavel Machek
2021-06-02 3:18 ` stuart hayes
2021-06-02 9:05 ` Pavel Machek
2021-06-02 15:36 ` stuart hayes
2021-06-02 22:40 ` Pavel Machek [this message]
2021-06-04 20:13 ` stuart hayes
2021-06-02 16:33 ` Marek Behún
2021-06-01 23:39 ` Randy Dunlap
2021-06-01 23:48 ` kernel test robot
2021-06-02 7:05 ` Lukas Wunner
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).