From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99632C4743C for ; Fri, 4 Jun 2021 22:25:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 792FA61406 for ; Fri, 4 Jun 2021 22:25:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231601AbhFDW1c (ORCPT ); Fri, 4 Jun 2021 18:27:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:36660 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229746AbhFDW1b (ORCPT ); Fri, 4 Jun 2021 18:27:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7F2C961402; Fri, 4 Jun 2021 22:25:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622845544; bh=WXG7b93sv97T1nEi/VGpsJ8KBWQ2EFw5X/pX0F9cxnE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=DGqyIwNx3EZAHON3djip9mCDZARk9nPz+2bvQFIXGFqJGp3iyHbFD5yVI2ZNkbSmn qTJXOxrQDvEHSLIaYsEEHdYYy73HxSku+S0JOeWR9uwvPsbVHZ9xxbzwspq2t+kff5 5za9S5eP/38bEFPU7ndV3KJFvF6eRbegx+NsjducIO2vUHMuipN4zCB12aFc7IdD3U MQFAJs01zO6efasUHLKaUm2FWqHEIHdS16hIPacjy2AeVEHt7FTPbwZFUK7AJJBHbR CdwGZfhZidFLBp+iUBYR9WvNvj2CGhB4Oxwtda746tyaveHixc/4bubOwiwR43Pir+ C25jhaDqoVhsQ== Date: Fri, 4 Jun 2021 17:25:42 -0500 From: Bjorn Helgaas To: Vinicius Costa Gomes Cc: intel-wired-lan@lists.osuosl.org, sasha.neftin@intel.com, anthony.l.nguyen@intel.com, linux-pci@vger.kernel.org, bhelgaas@google.com, netdev@vger.kernel.org, mlichvar@redhat.com, richardcochran@gmail.com, hch@infradead.org Subject: Re: [PATCH next-queue v4 1/4] Revert "PCI: Make pci_enable_ptm() private" Message-ID: <20210604222542.GA2246166@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210604220933.3974558-2-vinicius.gomes@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Jun 04, 2021 at 03:09:30PM -0700, Vinicius Costa Gomes wrote: > Make pci_enable_ptm() accessible from the drivers. > > Even if PTM still works on the platform I am using without calling > this function, it might be possible that it's not always the case. Not really relevant to this commit, strictly speaking. > Exposing this to the driver enables the driver to use the > 'ptm_enabled' field of 'pci_dev' to check if PTM is enabled or not. > > This reverts commit ac6c26da29c12fa511c877c273ed5c939dc9e96c. Ideally I would cite this as ac6c26da29c1 ("PCI: Make pci_enable_ptm() private") so there's a little more context. > Signed-off-by: Vinicius Costa Gomes > Acked-by: Bjorn Helgaas Acked regardless of the above. > --- > drivers/pci/pci.h | 3 --- > include/linux/pci.h | 7 +++++++ > 2 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h > index 37c913bbc6e1..32dab36c717e 100644 > --- a/drivers/pci/pci.h > +++ b/drivers/pci/pci.h > @@ -593,11 +593,8 @@ static inline void pcie_ecrc_get_policy(char *str) { } > > #ifdef CONFIG_PCIE_PTM > void pci_ptm_init(struct pci_dev *dev); > -int pci_enable_ptm(struct pci_dev *dev, u8 *granularity); > #else > static inline void pci_ptm_init(struct pci_dev *dev) { } > -static inline int pci_enable_ptm(struct pci_dev *dev, u8 *granularity) > -{ return -EINVAL; } > #endif > > struct pci_dev_reset_methods { > diff --git a/include/linux/pci.h b/include/linux/pci.h > index c20211e59a57..a687dda262dd 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -1617,6 +1617,13 @@ static inline bool pci_aer_available(void) { return false; } > > bool pci_ats_disabled(void); > > +#ifdef CONFIG_PCIE_PTM > +int pci_enable_ptm(struct pci_dev *dev, u8 *granularity); > +#else > +static inline int pci_enable_ptm(struct pci_dev *dev, u8 *granularity) > +{ return -EINVAL; } > +#endif > + > void pci_cfg_access_lock(struct pci_dev *dev); > bool pci_cfg_access_trylock(struct pci_dev *dev); > void pci_cfg_access_unlock(struct pci_dev *dev); > -- > 2.31.1 >