From: Bjorn Helgaas <helgaas@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Vidya Sagar" <vidyas@nvidia.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH V3] PCI: tegra: Fix building Tegra194 PCIe driver
Date: Mon, 7 Jun 2021 12:18:42 -0500 [thread overview]
Message-ID: <20210607171842.GA2507565@bjorn-Precision-5520> (raw)
In-Reply-To: <bc6345fa-12a6-aee3-7fa1-1703bcffa6a5@nvidia.com>
On Mon, Jun 07, 2021 at 04:50:34PM +0100, Jon Hunter wrote:
> Hi Bjorn, Lorenzo,
>
> On 26/05/2021 13:33, Jon Hunter wrote:
> > Commit 7f100744749e ("PCI: tegra: Add Tegra194 MCFG quirks for ECAM
> > errata") caused a few build regressions for the Tegra194 PCIe driver
> > which are:
> >
> > 1. The Tegra194 PCIe driver can no longer be built as a module. This
> > was caused by removing the Makefile entry to build the pcie-tegra.c
> > based upon the CONFIG_PCIE_TEGRA194 option. Therefore, restore this
> > so that we can build the driver as a module.
> > 2. 7f100744749e ("PCI: tegra: Add Tegra194 MCFG quirks for ECAM
> > errata") added "#ifdef CONFIG_PCIE_TEGRA194" around the native
> > driver. But if we set CONFIG_PCIE_TEGRA194=m to build the driver as a
> > module, autoconf.h contains "#define CONFIG_PCIE_TEGRA194_MODULE 1"
> > (not "#define CONFIG_PCIE_TEGRA194 1"), so the #ifdef excludes the
> > driver. Instead, use "IS_ENABLED(CONFIG_PCIE_TEGRA194)", which checks
> > for either CONFIG_PCIE_TEGRA194 or CONFIG_PCIE_TEGRA194_MODULE.
> > 3. The below build warnings that are seen with particular kernel
> > configurations. Fix these by moving these structure definitions to
> > within the necessary guards.
> >
> > drivers/pci/controller/dwc/pcie-tegra194.c:259:18: warning:
> > ‘event_cntr_data_offset’ defined but not used [-Wunused-const-variable=]
> > drivers/pci/controller/dwc/pcie-tegra194.c:250:18: warning:
> > ‘event_cntr_ctrl_offset’ defined but not used [-Wunused-const-variable=]
> > drivers/pci/controller/dwc/pcie-tegra194.c:243:27: warning:
> > ‘pcie_gen_freq’ defined but not used [-Wunused-const-variable=]
> >
> > Fixes: 7f100744749e ("PCI: tegra: Add Tegra194 MCFG quirks for ECAM errata")
> > Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>
>
> Any feedback on this? We need this for v5.13.
Thanks for the reminder, I'll take a look at this. It looks like we
broke this in v5.13-rc1, so we should fix it before v5.13.
next prev parent reply other threads:[~2021-06-07 17:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 12:33 [PATCH V3] PCI: tegra: Fix building Tegra194 PCIe driver Jon Hunter
2021-06-07 15:50 ` Jon Hunter
2021-06-07 17:18 ` Bjorn Helgaas [this message]
2021-06-07 18:19 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210607171842.GA2507565@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).