From: ChenXiaoSong <chenxiaosong2@huawei.com>
To: <jonnyc@amazon.com>, <lorenzo.pieralisi@arm.com>, <bhelgaas@google.com>
Cc: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<yukuai3@huawei.com>, <yi.zhang@huawei.com>,
<chenxiaosong2@huawei.com>
Subject: [PATCH -next,resend] PCI: al: Remove redundant dev_err call in al_pcie_probe()
Date: Tue, 8 Jun 2021 16:49:13 +0800 [thread overview]
Message-ID: <20210608084913.1046606-1-chenxiaosong2@huawei.com> (raw)
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: ChenXiaoSong <chenxiaosong2@huawei.com>
---
drivers/pci/controller/dwc/pcie-al.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-al.c b/drivers/pci/controller/dwc/pcie-al.c
index e8afa50129a8..fb4d1eed07ce 100644
--- a/drivers/pci/controller/dwc/pcie-al.c
+++ b/drivers/pci/controller/dwc/pcie-al.c
@@ -346,11 +346,8 @@ static int al_pcie_probe(struct platform_device *pdev)
controller_res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
"controller");
al_pcie->controller_base = devm_ioremap_resource(dev, controller_res);
- if (IS_ERR(al_pcie->controller_base)) {
- dev_err(dev, "couldn't remap controller base %pR\n",
- controller_res);
+ if (IS_ERR(al_pcie->controller_base))
return PTR_ERR(al_pcie->controller_base);
- }
dev_dbg(dev, "From DT: controller_base: %pR\n", controller_res);
--
2.25.4
next reply other threads:[~2021-06-08 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 8:49 ChenXiaoSong [this message]
2021-11-03 18:34 ` [PATCH -next,resend] PCI: al: Remove redundant dev_err call in al_pcie_probe() Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210608084913.1046606-1-chenxiaosong2@huawei.com \
--to=chenxiaosong2@huawei.com \
--cc=bhelgaas@google.com \
--cc=jonnyc@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).