From: Bjorn Helgaas <helgaas@kernel.org>
To: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc: Paul Menzel <pmenzel@molgen.mpg.de>,
linux-pci@vger.kernel.org, richardcochran@gmail.com,
hch@infradead.org, netdev@vger.kernel.org, bhelgaas@google.com,
intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH next-queue v5 3/4] igc: Enable PCIe PTM
Date: Wed, 9 Jun 2021 18:20:34 -0500 [thread overview]
Message-ID: <20210609232034.GA2681266@bjorn-Precision-5520> (raw)
In-Reply-To: <87k0n2vdqv.fsf@vcostago-mobl2.amr.corp.intel.com>
On Wed, Jun 09, 2021 at 04:07:20PM -0700, Vinicius Costa Gomes wrote:
> Hi Paul,
>
> >>
> >>> Regarding my comment, I did not mean returning an error but the log
> >>> *level* of the message. So, `dmesg --level err` would show that message.
> >>> But if there are PCI controllers not supporting that, it’s not an error,
> >>> but a warning at most. So, I’d use:
> >>>
> >>> dev_warn(&pdev->dev, "PTM not supported by PCI bus/controller
> >>> (pci_enable_ptm() failed)\n");
> >>
> >> I will use you suggestion for the message, but I think that warn is a
> >> bit too much, info or notice seem to be better.
> >
> > I do not know, if modern PCI(e)(?) controllers normally support PTM or
> > not. If recent controllers should support it, then a warning would be
> > warranted, otherwise a notice.
>
> From the Intel side, it seems that it's been supported for a few years.
> So, fair enough, let's go with a warn.
I'm not sure about this. I think "warning" messages interrupt distro
graphical boot scenarios and cause user complaints. In this case,
there is nothing broken and the user can do nothing about it; it's
merely a piece of missing optional functionality. So I think "info"
is a more appropriate level.
Bjorn
next prev parent reply other threads:[~2021-06-09 23:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 0:23 [PATCH next-queue v5 0/4] igc: Add support for PCIe PTM Vinicius Costa Gomes
2021-06-05 0:23 ` [PATCH next-queue v5 1/4] Revert "PCI: Make pci_enable_ptm() private" Vinicius Costa Gomes
2021-06-05 0:23 ` [PATCH next-queue v5 2/4] PCI: Add pcie_ptm_enabled() Vinicius Costa Gomes
2021-06-05 0:23 ` [PATCH next-queue v5 3/4] igc: Enable PCIe PTM Vinicius Costa Gomes
2021-06-05 6:42 ` [Intel-wired-lan] " Paul Menzel
2021-06-08 19:02 ` Vinicius Costa Gomes
2021-06-09 6:24 ` Paul Menzel
2021-06-09 20:08 ` Vinicius Costa Gomes
2021-06-09 21:26 ` Paul Menzel
2021-06-09 23:07 ` Vinicius Costa Gomes
2021-06-09 23:20 ` Bjorn Helgaas [this message]
2021-06-10 0:04 ` Vinicius Costa Gomes
2021-06-05 0:23 ` [PATCH next-queue v5 4/4] igc: Add support for PTP getcrosststamp() Vinicius Costa Gomes
2021-06-05 6:36 ` [Intel-wired-lan] " Paul Menzel
2021-06-08 22:02 ` Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210609232034.GA2681266@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=hch@infradead.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=richardcochran@gmail.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).