From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E95EC48BE5 for ; Wed, 23 Jun 2021 13:46:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 277BB61075 for ; Wed, 23 Jun 2021 13:46:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230449AbhFWNsr (ORCPT ); Wed, 23 Jun 2021 09:48:47 -0400 Received: from foss.arm.com ([217.140.110.172]:35622 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230206AbhFWNsr (ORCPT ); Wed, 23 Jun 2021 09:48:47 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C7A04ED1; Wed, 23 Jun 2021 06:46:29 -0700 (PDT) Received: from lpieralisi (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 90BBA3F718; Wed, 23 Jun 2021 06:46:28 -0700 (PDT) Date: Wed, 23 Jun 2021 14:46:23 +0100 From: Lorenzo Pieralisi To: Lucas Stach Cc: Bjorn Helgaas , Rob Herring , Richard Zhu , NXP Linux Team , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, patchwork-lst@pengutronix.de Subject: Re: [PATCH 1/7] PCI: imx6: Move i.MX8MQ controller instance check to correct case statement Message-ID: <20210623134623.GA14289@lpieralisi> References: <20210510141509.929120-1-l.stach@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210510141509.929120-1-l.stach@pengutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, May 10, 2021 at 04:15:03PM +0200, Lucas Stach wrote: > While the i.MX8MQ case falls through to the i.MX7D case, it's quite confusing > to have the i.MX8MQ specific controller instance check in that statement. > Move it to the 8MQ case. > > Signed-off-by: Lucas Stach > --- > drivers/pci/controller/dwc/pci-imx6.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Hi Lucas, it looks like some of the patches in this series need a respin, therefore I will mark it as "Changes Requested" unless there are some patches I can cherry pick - please let me know your plan. Thanks, Lorenzo > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 0cf1333c0440..46b5f070939e 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -1060,11 +1060,11 @@ static int imx6_pcie_probe(struct platform_device *pdev) > if (IS_ERR(imx6_pcie->pcie_aux)) > return dev_err_probe(dev, PTR_ERR(imx6_pcie->pcie_aux), > "pcie_aux clock source missing or invalid\n"); > - fallthrough; > - case IMX7D: > if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR) > imx6_pcie->controller_id = 1; > > + fallthrough; > + case IMX7D: > imx6_pcie->pciephy_reset = devm_reset_control_get_exclusive(dev, > "pciephy"); > if (IS_ERR(imx6_pcie->pciephy_reset)) { > -- > 2.29.2 >