From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CBDBC07E9E for ; Mon, 5 Jul 2021 21:23:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8052161976 for ; Mon, 5 Jul 2021 21:23:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230026AbhGEVZx (ORCPT ); Mon, 5 Jul 2021 17:25:53 -0400 Received: from mail-lf1-f48.google.com ([209.85.167.48]:46925 "EHLO mail-lf1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230006AbhGEVZw (ORCPT ); Mon, 5 Jul 2021 17:25:52 -0400 Received: by mail-lf1-f48.google.com with SMTP id p21so12842060lfj.13 for ; Mon, 05 Jul 2021 14:23:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z25jV3Lc+Jaa1XrFF2O29mwDomdRuLImlWbMu42JCcw=; b=o8ZxFas7UUNO8m/l8WPOXx3d8xm+CpeuVkdfUvB9ZvWQC8DPjRXfSs6vRhq5k6GJCY jtK2TCav1lQgkPj4Lsg+t4YXy7f16Vf+mPWXySgPcBya0gAH4prYAGYkur2E8jpH77Us y34q467FDnoploPuZQ8MqFRlrL080u/+KJ04EZS6oD5R0P2+3CbXnHIJpqSdMtDmUnKf yxgd6WgPI5Yi3qNa28hCIoQAaaazo03263K1hbk3NY9QAVzQHwohAm9PAN4sBnW7z5Z3 5Rd33G3RkcTiAv4g3Xb7RnQZT9R694cK6CTtWfAMOeS3eTh36DgVbYU2ol9PPMck39+Q rAPA== X-Gm-Message-State: AOAM530WsO35blU7LOhISX9VKDXrRen3UtEViLmTXwhwiQAEmVOc5ZMG SxCH5xjk48QCsYzhZTBdksg= X-Google-Smtp-Source: ABdhPJyNs2pjiHwDnBxvd8lPYpgh9YiuzhrMHdL6ty9/pKEgoXAZVS8ok3z10s3T8PWYhOGFAtvyMQ== X-Received: by 2002:a05:6512:3103:: with SMTP id n3mr11658069lfb.173.1625520193313; Mon, 05 Jul 2021 14:23:13 -0700 (PDT) Received: from workstation.lan ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id x1sm1191338lfa.21.2021.07.05.14.23.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jul 2021 14:23:12 -0700 (PDT) From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= To: Bjorn Helgaas Cc: Lorenzo Pieralisi , Kishon Vijay Abraham I , linux-pci@vger.kernel.org Subject: [PATCH 4/4] PCI: Don't use the strtobool() wrapper for kstrtobool() Date: Mon, 5 Jul 2021 21:23:08 +0000 Message-Id: <20210705212308.3050976-4-kw@linux.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210705212308.3050976-1-kw@linux.com> References: <20210705212308.3050976-1-kw@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org The strtobool() function is a wrapper over the kstrtobool() function that has been added for backward compatibility. There is no reason to use the old API, thus rather than using the wrapper use the kstrtobool() directly. Related: commit ef951599074b ("lib: move strtobool() to kstrtobool()") Signed-off-by: Krzysztof Wilczyński --- drivers/pci/p2pdma.c | 6 +++--- drivers/pci/pcie/aspm.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c index 196382630363..1bd299cf3872 100644 --- a/drivers/pci/p2pdma.c +++ b/drivers/pci/p2pdma.c @@ -911,7 +911,7 @@ EXPORT_SYMBOL_GPL(pci_p2pdma_unmap_sg_attrs); * * Parses an attribute value to decide whether to enable p2pdma. * The value can select a PCI device (using its full BDF device - * name) or a boolean (in any format strtobool() accepts). A false + * name) or a boolean (in any format kstrtobool() accepts). A false * value disables p2pdma, a true value expects the caller * to automatically find a compatible device and specifying a PCI device * expects the caller to use the specific provider. @@ -943,11 +943,11 @@ int pci_p2pdma_enable_store(const char *page, struct pci_dev **p2p_dev, } else if ((page[0] == '0' || page[0] == '1') && !iscntrl(page[1])) { /* * If the user enters a PCI device that doesn't exist - * like "0000:01:00.1", we don't want strtobool to think + * like "0000:01:00.1", we don't want kstrtobool to think * it's a '0' when it's clearly not what the user wanted. * So we require 0's and 1's to be exactly one character. */ - } else if (!strtobool(page, use_p2pdma)) { + } else if (!kstrtobool(page, use_p2pdma)) { return 0; } diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c index ac0557a305af..ba8b17000d94 100644 --- a/drivers/pci/pcie/aspm.c +++ b/drivers/pci/pcie/aspm.c @@ -1219,7 +1219,7 @@ static ssize_t aspm_attr_store_common(struct device *dev, struct pcie_link_state *link = pcie_aspm_get_link(pdev); bool state_enable; - if (strtobool(buf, &state_enable) < 0) + if (kstrtobool(buf, &state_enable) < 0) return -EINVAL; down_read(&pci_bus_sem); @@ -1276,7 +1276,7 @@ static ssize_t clkpm_store(struct device *dev, struct pcie_link_state *link = pcie_aspm_get_link(pdev); bool state_enable; - if (strtobool(buf, &state_enable) < 0) + if (kstrtobool(buf, &state_enable) < 0) return -EINVAL; down_read(&pci_bus_sem); -- 2.32.0