From: Lukas Wunner <lukas@wunner.de>
To: stuart hayes <stuart.w.hayes@gmail.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Ethan Zhao <haifeng.zhao@intel.com>,
Sinan Kaya <okaya@kernel.org>, Ashok Raj <ashok.raj@intel.com>,
Keith Busch <kbusch@kernel.org>,
Yicong Yang <yangyicong@hisilicon.com>,
linux-pci@vger.kernel.org, Russell Currey <ruscur@russell.cc>,
Oliver OHalloran <oohall@gmail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v2] PCI: pciehp: Ignore Link Down/Up caused by DPC
Date: Sun, 18 Jul 2021 23:26:09 +0200 [thread overview]
Message-ID: <20210718212609.GA12573@wunner.de> (raw)
In-Reply-To: <661f1019-da20-6656-989f-2e7dea240fc4@gmail.com>
On Tue, Jul 06, 2021 at 05:15:02PM -0500, stuart hayes wrote:
> I believe the Link Down is happening because a hot reset is propagated down
> when the link is lost under the root port 64:02.0. From the PCIe Base Spec
> 5.0, section 6.6.1 "conventional reset":
[...]
Hm, sounds plausible. Just so that I understand this correctly,
the hotplug port at 0000:68:00.0 is DPC-capable, but the error
that is contained by DPC at the Root Port occurs further up in
the hierarchy, right? (I.e. somewhere above the hotplug port.)
The patch you're using to work around the issue would break if
the hotplug port is *not* DPC-capable. Yes, yes, I understand
that it's not meant as a real patch, but it shows how tricky
it is to fix the issue. I need to do a little more thinking
what a proper solution could look like.
Thanks,
Lukas
next prev parent reply other threads:[~2021-07-18 21:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 8:29 [PATCH v2] PCI: pciehp: Ignore Link Down/Up caused by DPC Lukas Wunner
2021-05-01 8:38 ` Lukas Wunner
2021-06-16 22:19 ` Bjorn Helgaas
2021-06-20 7:38 ` Lukas Wunner
2021-06-25 20:38 ` stuart hayes
2021-06-26 6:50 ` Lukas Wunner
2021-07-06 22:15 ` stuart hayes
2021-07-18 21:26 ` Lukas Wunner [this message]
2021-07-19 15:10 ` Lukas Wunner
2021-07-19 19:00 ` stuart hayes
2021-07-20 6:57 ` Lukas Wunner
2021-07-20 22:11 ` stuart hayes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210718212609.GA12573@wunner.de \
--to=lukas@wunner.de \
--cc=ashok.raj@intel.com \
--cc=dan.j.williams@intel.com \
--cc=haifeng.zhao@intel.com \
--cc=helgaas@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=okaya@kernel.org \
--cc=oohall@gmail.com \
--cc=ruscur@russell.cc \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=stuart.w.hayes@gmail.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).