From: "Krzysztof Wilczyński" <kw@linux.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
Subject: [PATCH 3/4] PCI/sysfs: Add pci_dev_resource_group() macro
Date: Wed, 25 Aug 2021 21:22:54 +0000 [thread overview]
Message-ID: <20210825212255.878043-4-kw@linux.com> (raw)
In-Reply-To: <20210825212255.878043-1-kw@linux.com>
The pci_dev_resource_group() macro will be used to reduce unnecessary
code repetition following the use of the pci_dev_resource_attr() macro
when adding each of the many newly created resource groups to the list
of other PCI sysfs objects stored in the pci_dev_groups array.
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
drivers/pci/pci-sysfs.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 6eba5c0887df..97ab9da47dca 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -1324,6 +1324,11 @@ attribute_group pci_dev_resource##_bar##_wc_attr_group = { \
.bin_attrs = pci_dev_resource##_bar##_wc_attrs, \
.is_bin_visible = pci_dev_resource##_bar##_wc_attr_is_visible, \
}
+
+#define pci_dev_resource_group(_bar) \
+ &pci_dev_resource##_bar##_attr_group, \
+ &pci_dev_resource##_bar##_wc_attr_group
+
#else /* !(defined(HAVE_PCI_MMAP) || defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)) */
int __weak pci_create_resource_files(struct pci_dev *dev) { return 0; }
void __weak pci_remove_resource_files(struct pci_dev *dev) { return; }
--
2.32.0
next prev parent reply other threads:[~2021-08-25 21:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 21:22 [PATCH 0/4] PCI: Convert dynamic PCI resources sysfs objects into static Krzysztof Wilczyński
2021-08-25 21:22 ` [PATCH 1/4] PCI/sysfs: Add pci_dev_resource_attr_is_visible() helper Krzysztof Wilczyński
2021-08-26 23:35 ` Bjorn Helgaas
2021-08-27 12:11 ` Greg Kroah-Hartman
2021-08-27 22:23 ` Bjorn Helgaas
2021-09-10 14:08 ` Greg Kroah-Hartman
2021-09-10 17:21 ` Krzysztof Wilczyński
2021-09-11 10:13 ` Greg Kroah-Hartman
2021-09-13 19:47 ` Bjorn Helgaas
2021-09-14 5:06 ` Greg Kroah-Hartman
2021-09-10 16:12 ` Krzysztof Wilczyński
2021-08-25 21:22 ` [PATCH 2/4] PCI/sysfs: Add pci_dev_resource_attr() macro Krzysztof Wilczyński
2021-08-26 21:12 ` Bjorn Helgaas
2021-08-25 21:22 ` Krzysztof Wilczyński [this message]
2021-08-25 21:22 ` [PATCH 4/4] PCI/sysfs: Convert PCI resource files to static attributes Krzysztof Wilczyński
2021-08-25 23:02 ` [PATCH 0/4] PCI: Convert dynamic PCI resources sysfs objects into static Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825212255.878043-4-kw@linux.com \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).