From: Bjorn Helgaas <helgaas@kernel.org>
To: Huacai Chen <chenhuacai@loongson.cn>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org,
Xuefeng Li <lixuefeng@loongson.cn>,
Huacai Chen <chenhuacai@gmail.com>
Subject: Re: [PATCH V4 00/10] PCI/VGA: Rework default VGA device selection
Date: Thu, 9 Sep 2021 12:59:26 -0500 [thread overview]
Message-ID: <20210909175926.GA996660@bjorn-Precision-5520> (raw)
In-Reply-To: <20210827083129.2781420-1-chenhuacai@loongson.cn>
On Fri, Aug 27, 2021 at 04:31:19PM +0800, Huacai Chen wrote:
> My original work is at [1].
>
> Bjorn do some rework and extension in V2. It moves the VGA arbiter to
> the PCI subsystem, fixes a few nits, and breaks a few pieces to make
> the main patch a little smaller.
>
> V3 rewrite the commit log of the last patch (which is also summarized
> by Bjorn).
>
> V4 split the last patch to two steps.
>
> All comments welcome!
I'm hoping to apply something like this for v5.16.
BUT as I mentioned in [2], I want the very first patch to be the very
simple 2-line change to vga_arb_update_default_device() that actually
fixes your problem.
It makes no sense for that change to be at the very end, hidden in the
middle of a bigger restructuring patch.
[2] https://lore.kernel.org/r/20210825201704.GA3600046@bjorn-Precision-5520
> [1] https://lore.kernel.org/dri-devel/20210705100503.1120643-1-chenhuacai@loongson.cn/
>
> Bjorn Helgaas (4):
> PCI/VGA: Move vgaarb to drivers/pci
> PCI/VGA: Replace full MIT license text with SPDX identifier
> PCI/VGA: Use unsigned format string to print lock counts
> PCI/VGA: Remove empty vga_arb_device_card_gone()
>
> Huacai Chen (6):
> PCI/VGA: Move vga_arb_integrated_gpu() earlier in file
> PCI/VGA: Prefer vga_default_device()
> PCI/VGA: Split out vga_arb_update_default_device()
> PCI/VGA: Log bridge control messages when adding devices
> PCI/VGA: Rework default VGA device selection (Step 1)
> PCI/VGA: Rework default VGA device selection (Step 2)
>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> drivers/gpu/vga/Kconfig | 19 ---
> drivers/gpu/vga/Makefile | 1 -
> drivers/pci/Kconfig | 19 +++
> drivers/pci/Makefile | 1 +
> drivers/{gpu/vga => pci}/vgaarb.c | 269 ++++++++++++------------------
> 5 files changed, 126 insertions(+), 183 deletions(-)
> rename drivers/{gpu/vga => pci}/vgaarb.c (90%)
> --
> 2.27.0
>
next prev parent reply other threads:[~2021-09-09 17:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 8:31 [PATCH V4 00/10] PCI/VGA: Rework default VGA device selection Huacai Chen
2021-08-27 8:31 ` [PATCH V4 01/10] PCI/VGA: Move vgaarb to drivers/pci Huacai Chen
2021-08-27 8:31 ` [PATCH V4 02/10] PCI/VGA: Replace full MIT license text with SPDX identifier Huacai Chen
2021-08-27 8:31 ` [PATCH V4 03/10] PCI/VGA: Use unsigned format string to print lock counts Huacai Chen
2021-08-27 8:31 ` [PATCH V4 04/10] PCI/VGA: Remove empty vga_arb_device_card_gone() Huacai Chen
2021-08-27 8:31 ` [PATCH V4 05/10] PCI/VGA: Move vga_arb_integrated_gpu() earlier in file Huacai Chen
2021-08-27 8:31 ` [PATCH V4 06/10] PCI/VGA: Prefer vga_default_device() Huacai Chen
2021-08-27 8:31 ` [PATCH V4 07/10] PCI/VGA: Split out vga_arb_update_default_device() Huacai Chen
2021-08-27 8:31 ` [PATCH V4 08/10] PCI/VGA: Log bridge control messages when adding devices Huacai Chen
2021-08-27 8:31 ` [PATCH V4 09/10] PCI/VGA: Rework default VGA device selection (Step 1) Huacai Chen
2021-08-27 8:31 ` [PATCH V4 10/10] PCI/VGA: Rework default VGA device selection (Step 2) Huacai Chen
2021-09-09 17:59 ` Bjorn Helgaas [this message]
2021-09-11 9:17 ` [PATCH V4 00/10] PCI/VGA: Rework default VGA device selection Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210909175926.GA996660@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=airlied@linux.ie \
--cc=bhelgaas@google.com \
--cc=chenhuacai@gmail.com \
--cc=chenhuacai@loongson.cn \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-pci@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).