From: Bjorn Helgaas <helgaas@kernel.org>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-pci <linux-pci@vger.kernel.org>,
"open list:MIPS" <linux-mips@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
John Crispin <john@phrozen.org>, NeilBrown <neil@brown.name>,
Greg KH <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v3 0/3] PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver
Date: Thu, 21 Oct 2021 13:11:45 -0500 [thread overview]
Message-ID: <20211021181145.GA2708516@bhelgaas> (raw)
In-Reply-To: <CAMhs-H-BA+KzEwuDPzcmrDPdgJBFA2XdYTBvT4R4MEOUB=WQ1g@mail.gmail.com>
On Thu, Oct 21, 2021 at 07:27:21PM +0200, Sergio Paracuellos wrote:
> On Thu, Oct 21, 2021 at 5:52 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> > Since this is a PCIe (not conventional PCI) controller, I vote for
> > renaming these from:
> >
> > PCI_MT7621
> > Documentation/devicetree/bindings/pci/mediatek,mt7621-pci.yaml
> > drivers/pci/controller/pci-mt7621.c
> >
> > to:
> >
> > PCIE_MT7621
> > Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> > drivers/pci/controller/pcie-mt7621.c
> >
> > We have a mix of these, with many of the early PCIe drivers being
> > named "pci", but I think that was my mistake and there's no reason to
> > continue it.
>
> I see.
>
> >
> > I can do this locally unless somebody objects.
>
> I have no problem at all. Only one question. Do you mean to change
> compatible string also, or only the name of the file? Let me know if I
> have to do anything.
I didn't change the compatible string, to avoid a DT incompatibility.
But I *did* change the Kconfig symbol to PCIE_MT7621, which could
require changes to out-of-tree .configs. I'm open to suggestions
either way for both things.
next prev parent reply other threads:[~2021-10-21 18:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 5:00 [PATCH v3 0/3] PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver Sergio Paracuellos
2021-09-22 5:00 ` [PATCH v3 1/3] dt-bindings: mt7621-pci: PCIe binding documentation for MT7621 SoCs Sergio Paracuellos
2021-09-22 5:00 ` [PATCH v3 2/3] PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver Sergio Paracuellos
2021-10-13 13:05 ` Lorenzo Pieralisi
2021-10-13 13:35 ` Sergio Paracuellos
2021-09-22 5:00 ` [PATCH v3 3/3] MAINTAINERS: add myself as maintainer of the MT7621 PCI " Sergio Paracuellos
2021-09-22 9:05 ` Sergei Shtylyov
2021-10-03 16:55 ` Sergio Paracuellos
2021-10-20 14:23 ` [PATCH v3 0/3] PCI: mt7621: Add MediaTek MT7621 PCIe host " Lorenzo Pieralisi
2021-10-20 14:56 ` Sergio Paracuellos
2021-10-21 15:52 ` Bjorn Helgaas
2021-10-21 17:27 ` Sergio Paracuellos
2021-10-21 18:11 ` Bjorn Helgaas [this message]
2021-10-21 19:23 ` Sergio Paracuellos
2021-10-22 8:34 ` Lorenzo Pieralisi
2021-10-22 9:13 ` Sergio Paracuellos
2021-10-25 21:12 ` Bjorn Helgaas
2021-10-26 5:49 ` Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211021181145.GA2708516@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=neil@brown.name \
--cc=sergio.paracuellos@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).