From: Bjorn Helgaas <helgaas@kernel.org>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Anthony Wong" <anthony.wong@canonical.com>,
"Linux PCI" <linux-pci@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Vidya Sagar" <vidyas@nvidia.com>,
"Logan Gunthorpe" <logang@deltatee.com>
Subject: Re: [PATCH v2 3/3] PCI/ASPM: Add LTR sysfs attributes
Date: Tue, 26 Oct 2021 11:53:48 -0500 [thread overview]
Message-ID: <20211026165348.GA146058@bhelgaas> (raw)
In-Reply-To: <CAAd53p7cqnGmySsxSz1xTmUp=_O_vApMuvcg-cBFUHButpva7Q@mail.gmail.com>
On Tue, Oct 26, 2021 at 10:28:38AM +0800, Kai-Heng Feng wrote:
> What if we fallback to the original approach and use the VMD driver
> to enable ASPM and LTR values? At least I think Intel should be
> able to provide correct values for their SoC.
Can you post the patches for that? I'm not sure exactly what the
original approach was. Are these the same as the downstream support
you mention below?
> So what other options do we have if we want to enable VMD ASPM while
> keeping CONFIG_PCIEASPM_DEFAULT=y? Right now we enabled the VMD
> ASPM/LTR bits in downstream kernel, but other distro users may want
> to have upstream support for this.
next prev parent reply other threads:[~2021-10-26 16:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 3:51 [PATCH v2 0/3] Let user enable ASPM and LTR via sysfs Kai-Heng Feng
2021-10-21 3:51 ` [PATCH v2 1/3] PCI/ASPM: Store disabled ASPM states Kai-Heng Feng
2021-10-21 3:51 ` [PATCH v2 2/3] PCI/ASPM: Use capability to override ASPM via sysfs Kai-Heng Feng
2021-10-21 3:51 ` [PATCH v2 3/3] PCI/ASPM: Add LTR sysfs attributes Kai-Heng Feng
2021-10-21 15:09 ` Bjorn Helgaas
2021-10-25 10:33 ` Kai-Heng Feng
2021-10-25 17:31 ` Bjorn Helgaas
2021-10-26 2:28 ` Kai-Heng Feng
2021-10-26 16:53 ` Bjorn Helgaas [this message]
2021-10-28 5:16 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211026165348.GA146058@bhelgaas \
--to=helgaas@kernel.org \
--cc=anthony.wong@canonical.com \
--cc=bhelgaas@google.com \
--cc=hkallweit1@gmail.com \
--cc=kai.heng.feng@canonical.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).