From: Bjorn Helgaas <helgaas@kernel.org>
To: Robin McCorkell <robin@mccorkell.me.uk>
Cc: linux-pci@vger.kernel.org, stable@vger.kernel.org,
"Christian König" <christian.koenig@amd.com>,
"Nirmoy Das" <nirmoy.das@amd.com>
Subject: Re: [PATCH v2] PCI: Limit REBAR quirk to just Sapphire RX 5600 XT Pulse
Date: Mon, 1 Nov 2021 16:55:16 -0500 [thread overview]
Message-ID: <20211101215516.GA554197@bhelgaas> (raw)
In-Reply-To: <20211026214513.25986-1-robin@mccorkell.me.uk>
[+cc Christian, Nirmoy]
On Tue, Oct 26, 2021 at 10:44:59PM +0100, Robin McCorkell wrote:
> A particular RX 5600 device requires a hack in the rebar logic, but the
> current branch is too general and catches other devices too, breaking
> them. This patch changes the branch to be more selective on the
> particular revision.
>
> This patch fixes intermittent freezes on other RX 5600 devices where the
> hack is unnecessary. Credit to all contributors in the linked issue on
> the AMD bug tracker.
>
> See also: https://gitlab.freedesktop.org/drm/amd/-/issues/1707
>
> Fixes: 907830b0fc9e ("PCI: Add a REBAR size quirk for Sapphire RX 5600 XT Pulse")
> Cc: stable@vger.kernel.org # v5.12+
> Signed-off-by: Robin McCorkell <robin@mccorkell.me.uk>
> Reported-by: Simon May <@Socob on gitlab.freedesktop.com>
> Tested-by: Kain Centeno <@kaincenteno on gitlab.freedesktop.com>
> Tested-by: Tobias Jakobi <@tobiasjakobi on gitlab.freedesktop.com>
> Suggested-by: lijo lazar <@lijo on gitlab.freedesktop.com>
I'll wait for an ack from Christian on this one, since it doesn't seem
to make sense to him.
> ---
> drivers/pci/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index ce2ab62b64cf..1fe75243019e 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -3647,7 +3647,7 @@ u32 pci_rebar_get_possible_sizes(struct pci_dev *pdev, int bar)
>
> /* Sapphire RX 5600 XT Pulse has an invalid cap dword for BAR 0 */
> if (pdev->vendor == PCI_VENDOR_ID_ATI && pdev->device == 0x731f &&
> - bar == 0 && cap == 0x7000)
> + pdev->revision == 0xC1 && bar == 0 && cap == 0x7000)
> cap = 0x3f000;
>
> return cap >> 4;
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-11-01 21:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 20:46 [PATCH] Limit AMD Radeon rebar hack to a single revision Robin McCorkell
2021-10-26 21:28 ` Bjorn Helgaas
2021-10-26 21:44 ` [PATCH v2] PCI: Limit REBAR quirk to just Sapphire RX 5600 XT Pulse Robin McCorkell
2021-10-27 9:47 ` Krzysztof Wilczyński
2021-11-01 21:55 ` Bjorn Helgaas [this message]
2021-11-02 12:27 ` Christian König
2021-10-26 21:49 ` [PATCH] Limit AMD Radeon rebar hack to a single revision Robin McCorkell
2021-10-27 6:38 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211101215516.GA554197@bhelgaas \
--to=helgaas@kernel.org \
--cc=christian.koenig@amd.com \
--cc=linux-pci@vger.kernel.org \
--cc=nirmoy.das@amd.com \
--cc=robin@mccorkell.me.uk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).