From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: linux-pci@vger.kernel.org
Cc: tsbogend@alpha.franken.de, lorenzo.pieralisi@arm.com,
bhelgaas@google.com, linux@roeck-us.net,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 0/5] PCI: mt7621: Remove specific MIPS code from driver
Date: Tue, 7 Dec 2021 11:49:19 +0100 [thread overview]
Message-ID: <20211207104924.21327-1-sergio.paracuellos@gmail.com> (raw)
Hi all,
MIPS specific code can be removed from driver and put into ralink mt7621
instead which is a more accurate place to do this. To make this possible
we need to have access to 'bridge->windows' in 'pcibios_root_bridge_prepare()'
which has been implemented for ralink mt7621 platform (there is no real
need to implement this for any other platforms since those ones haven't got
I/O coherency units). This also allow us to properly enable this driver to
completely be enabled for COMPILE_TEST. This patchset appoarch:
- Move windows list splice in 'pci_register_host_bridge()' after function
'pcibios_root_bridge_prepare()' is called.
- Implement 'pcibios_root_bridge_prepare()' for ralink mt7621.
- Avoid custom MIPs code in pcie-mt7621 driver.
- Add missing 'MODULE_LICENSE()' to pcie-mt7621 driver to avoid compile test
module compilation to complain (already sent patch from Yanteng Si that
I have rewrite commit message and long description a bit.
- Remove MIPS conditional code from Kconfig and mark driver as 'tristate'.
This patchset is a real fix for some errors reported by Kernel Test Robot about
implicit mips functions used in driver code and fix errors in driver when
is compiled as a module [1] (mips:allmodconfig).
Changes in v3:
- Rebase the series on the top of the temporal fix sent for v5.16[3] for
the module compilation problem.
- Address review comments from Guenter in PATCH 2 (thanks Guenter!):
- Address TODO in comment about the hardware does not allow zeros
after 1s for the mask and WARN_ON if that's happend.
- Be sure mask is real valid upper 16 bits.
Changes in v2:
- Collect Acked-by from Arnd Bergmann for PATCH 1.
- Collect Reviewed-by from Krzysztof Wilczyński for PATCH 4.
- Adjust some patches commit subject and message as pointed out by Bjorn in review of v1 of the series[2].
This patchset is the good way of properly compile driver as a module removing
all MIPS specific code into arch ralink mt7621 place. To avoid mips:allmodconfig reported
problems for v5.16 the following patch has been sent[3]. This series are rebased onto this patch to provide
a real fix for this problem.
[0]: https://lore.kernel.org/linux-mips/CAMhs-H8ShoaYiFOOzJaGC68nZz=V365RXN_Kjuj=fPFENGJiiw@mail.gmail.com/T/#t
[1]: https://lkml.org/lkml/2021/11/14/436
[2]: https://lore.kernel.org/r/20211115070809.15529-1-sergio.paracuellos@gmail.com
[3]: https://lore.kernel.org/linux-pci/20211203192454.32624-1-sergio.paracuellos@gmail.com/T/#u
Thanks in advance for your time.
Best regards,
Sergio Paracuellos
Sergio Paracuellos (5):
PCI: Let pcibios_root_bridge_prepare() access to 'bridge->windows'
MIPS: ralink: implement 'pcibios_root_bridge_prepare()'
PCI: mt7621: Avoid custom MIPS code in driver code
PCI: mt7621: Add missing 'MODULE_LICENSE()' definition
PCI: mt7621: Allow COMPILE_TEST for all arches
arch/mips/ralink/mt7621.c | 31 ++++++++++++++++++++++
drivers/pci/controller/Kconfig | 4 +--
drivers/pci/controller/pcie-mt7621.c | 39 ++--------------------------
drivers/pci/probe.c | 4 +--
4 files changed, 37 insertions(+), 41 deletions(-)
--
2.33.0
next reply other threads:[~2021-12-07 10:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 10:49 Sergio Paracuellos [this message]
2021-12-07 10:49 ` [PATCH v3 1/5] PCI: Let pcibios_root_bridge_prepare() access to 'bridge->windows' Sergio Paracuellos
2021-12-07 10:49 ` [PATCH v3 2/5] MIPS: ralink: implement 'pcibios_root_bridge_prepare()' Sergio Paracuellos
2022-01-12 18:20 ` Guenter Roeck
2022-01-12 20:10 ` Sergio Paracuellos
2022-01-12 20:10 ` Thomas Bogendoerfer
2022-01-13 5:53 ` Sergio Paracuellos
2021-12-07 10:49 ` [PATCH v3 3/5] PCI: mt7621: Avoid custom MIPS code in driver code Sergio Paracuellos
2021-12-07 10:49 ` [PATCH v3 4/5] PCI: mt7621: Add missing 'MODULE_LICENSE()' definition Sergio Paracuellos
2021-12-07 10:49 ` [PATCH v3 5/5] PCI: mt7621: Allow COMPILE_TEST for all arches Sergio Paracuellos
2022-01-12 14:42 ` [PATCH v3 0/5] PCI: mt7621: Remove specific MIPS code from driver Sergio Paracuellos
2022-01-12 18:06 ` Lorenzo Pieralisi
2022-01-12 18:21 ` Guenter Roeck
2022-01-12 20:09 ` Sergio Paracuellos
2022-01-12 21:52 ` Bjorn Helgaas
2022-01-13 5:52 ` Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211207104924.21327-1-sergio.paracuellos@gmail.com \
--to=sergio.paracuellos@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lorenzo.pieralisi@arm.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).