From: "Michał Winiarski" <michal.winiarski@intel.com>
To: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: "Christian König" <christian.koenig@amd.com>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Michael J . Ruhl" <michael.j.ruhl@intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Michał Winiarski" <michal.winiarski@intel.com>
Subject: [PATCH 2/2] PCI: Don't fail BAR resize if nothing is reassigned
Date: Wed, 15 Dec 2021 15:16:26 +0100 [thread overview]
Message-ID: <20211215141626.3090807-3-michal.winiarski@intel.com> (raw)
In-Reply-To: <20211215141626.3090807-1-michal.winiarski@intel.com>
When pci_reassign_bridge_resources returns -ENOENT, it means that no
resources needed to be "moved". This can happen when the resource was
resized to be smaller, and it's completely fine - there's no need to treat
this as an error and go back to the original BAR size.
Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
---
drivers/pci/setup-res.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c
index 1946e52e7678a..5de5129055e0a 100644
--- a/drivers/pci/setup-res.c
+++ b/drivers/pci/setup-res.c
@@ -484,7 +484,7 @@ int pci_resize_resource(struct pci_dev *dev, int resno, int size)
/* Check if the new config works by trying to assign everything. */
if (dev->bus->self) {
ret = pci_reassign_bridge_resources(dev->bus->self, res->flags);
- if (ret)
+ if (ret && ret != -ENOENT)
goto error_resize;
}
return 0;
--
2.34.0
next prev parent reply other threads:[~2021-12-15 14:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 14:16 [PATCH 0/2] PCI: VF resizable BAR Michał Winiarski
2021-12-15 14:16 ` [PATCH 1/2] PCI: Add support for VF Resizable Bar extended cap Michał Winiarski
2021-12-16 0:21 ` Krzysztof Wilczyński
2021-12-17 12:38 ` Michał Winiarski
2021-12-16 7:50 ` Christian König
2021-12-17 10:58 ` Michał Winiarski
2021-12-15 14:16 ` Michał Winiarski [this message]
2021-12-16 7:12 ` [PATCH 2/2] PCI: Don't fail BAR resize if nothing is reassigned Christian König
2021-12-17 11:23 ` Michał Winiarski
2021-12-17 12:45 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211215141626.3090807-3-michal.winiarski@intel.com \
--to=michal.winiarski@intel.com \
--cc=ardb@kernel.org \
--cc=bhelgaas@google.com \
--cc=christian.koenig@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=michael.j.ruhl@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).