From: Bjorn Helgaas <helgaas@kernel.org>
To: Stefan Roese <sr@denx.de>
Cc: linux-pci@vger.kernel.org,
"Bharat Kumar Gogada" <bharat.kumar.gogada@xilinx.com>,
"Pali Rohár" <pali@kernel.org>,
"Michal Simek" <michal.simek@xilinx.com>
Subject: Re: [RESEND PATCH v2 1/4] PCI: Add setup_platform_service_irq hook to struct pci_host_bridge
Date: Wed, 12 Jan 2022 10:20:32 -0600 [thread overview]
Message-ID: <20220112162032.GA260336@bhelgaas> (raw)
In-Reply-To: <20220112094251.1271531-1-sr@denx.de>
On Wed, Jan 12, 2022 at 10:42:48AM +0100, Stefan Roese wrote:
> From: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>
>
> As per section 6.2.4.1.2, 6.2.6 in PCIe r4.0 error interrupts can
> be delivered with platform specific interrupt lines.
> Add setup_platform_service_irq hook to struct pci_host_bridge.
> Some platforms have dedicated interrupt line from root complex to
> interrupt controller for PCIe services like AER.
> This hook is to register platform IRQ's to PCIe port services.
>
> Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Tested-by: Stefan Roese <sr@denx.de>
> Cc: Bjorn Helgaas <helgaas@kernel.org>
> Cc: Pali Rohár <pali@kernel.org>
> Cc: Michal Simek <michal.simek@xilinx.com>
It would be nice if this included a cover letter like Bharat's
original posting did [1]. That makes it easier to keep organized.
The PCIe r6.0 spec just came out, so let's update the spec references
to that. Conveniently, the section numbers stayed the same as they
were in r4.0.
Update the language here to use the spec terminology, i.e.,
"platform-specific System Errors" That helps find the related bits,
e.g., "System Error on Correctable Error Enable" in the Root Control
register.
Rewrap this into paragraphs separated by blank lines.
[1] https://lore.kernel.org/all/1542206878-24587-1-git-send-email-bharat.kumar.gogada@xilinx.com/
> ---
> include/linux/pci.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 18a75c8e615c..291eadade811 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -554,6 +554,8 @@ struct pci_host_bridge {
> u8 (*swizzle_irq)(struct pci_dev *, u8 *); /* Platform IRQ swizzler */
> int (*map_irq)(const struct pci_dev *, u8, u8);
> void (*release_fn)(struct pci_host_bridge *);
> + void (*setup_platform_service_irq)(struct pci_host_bridge *, int *,
> + int);
> void *release_data;
> unsigned int ignore_reset_delay:1; /* For entire hierarchy */
> unsigned int no_ext_tags:1; /* No Extended Tags */
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-01-12 16:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 9:42 [RESEND PATCH v2 1/4] PCI: Add setup_platform_service_irq hook to struct pci_host_bridge Stefan Roese
2022-01-12 9:42 ` [RESEND PATCH v2 2/4] PCI: Add pci_check_platform_service_irqs Stefan Roese
2022-01-12 16:42 ` Bjorn Helgaas
2022-01-13 9:08 ` Stefan Roese
2022-01-12 9:42 ` [RESEND PATCH v2 3/4] PCI/portdrv: Check platform supported service IRQ's Stefan Roese
2022-01-12 10:34 ` Pali Rohár
2022-01-12 16:36 ` Bjorn Helgaas
2022-01-13 9:04 ` Stefan Roese
2022-01-12 9:42 ` [RESEND PATCH v2 4/4] PCI: xilinx-nwl: Add method to setup_platform_service_irq hook Stefan Roese
2022-01-12 10:23 ` [RESEND PATCH v2 1/4] PCI: Add setup_platform_service_irq hook to struct pci_host_bridge Pali Rohár
2022-01-13 8:42 ` Stefan Roese
2022-01-12 16:20 ` Bjorn Helgaas [this message]
2022-01-13 8:46 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220112162032.GA260336@bhelgaas \
--to=helgaas@kernel.org \
--cc=bharat.kumar.gogada@xilinx.com \
--cc=linux-pci@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=pali@kernel.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).