linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"helgaas@kernel.org" <helgaas@kernel.org>,
	"anatoli.antonovitch@amd.com" <anatoli.antonovitch@amd.com>,
	"Kumar1, Rahul" <Rahul.Kumar1@amd.com>,
	"Alexander.Deucher@amd.com" <Alexander.Deucher@amd.com>
Subject: Re: Question about deadlock between AER and pceihp interrupts during resume from S3 with unplugged device
Date: Thu, 10 Feb 2022 22:37:32 +0100	[thread overview]
Message-ID: <20220210213732.GA25592@wunner.de> (raw)
In-Reply-To: <6da46e96-8d71-3159-d4e1-0c744fb357ba@amd.com>

On Thu, Feb 10, 2022 at 03:47:10PM -0500, Andrey Grodzovsky wrote:
> So the patches indeed helped resolving the deadlock but when we try
> again to hotplug back there is a link status failure
> 
> pcieport 0000:00:01.1: pciehp: Slot(0): Card present
> pcieport 0000:00:01.1: Data Link Layer Link Active not set in 1000 msec
> pcieport 0000:00:01.1: pciehp: Failed to check link status
> 
> and more detailed  bellow,
> we are trying to debug but again, you might have a quick insight

Well, the link doesn't come up.  Is the Link Disable bit in the
Link Control Register set for some reason?  Perhaps some ACPI method
fiddled with it?

Compare the output of lspci -vv before and after the system sleep
transition, do you see anything suspicious?

If you reset the slot via sysfs, does the link come back up?

You may want to open a bug over at bugzilla.kernel.org and attach
the full dmesg output which didn't reach the list, as well as lspci
output.

Did you apply only my deadlock fix or also Kai-Heng Feng's AER disablement
patch?

Thanks,

Lukas

  reply	other threads:[~2022-02-10 21:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0fc31d9a-f414-a412-3765-5519cbb9b7ff@amd.com>
2022-02-09 21:28 ` Question about deadlock between AER and pceihp interrupts during resume from S3 with unplugged device Andrey Grodzovsky
2022-02-10  6:23 ` Lukas Wunner
2022-02-10 14:39   ` Andrey Grodzovsky
2022-06-10 21:25     ` Andrey Grodzovsky
2022-06-14 18:07       ` Andrey Grodzovsky
2022-06-14 18:22         ` Sathyanarayanan Kuppuswamy
2022-06-14 20:35           ` Andrey Grodzovsky
2022-06-15 15:14             ` Sathyanarayanan Kuppuswamy
2022-06-15 15:49               ` Andrey Grodzovsky
2022-02-10 20:47   ` Andrey Grodzovsky
2022-02-10 21:37     ` Lukas Wunner [this message]
2022-02-10 23:12       ` Andrey Grodzovsky
2022-02-11 14:42       ` Kumar1, Rahul
2022-02-15  7:02         ` Lukas Wunner
2022-02-15  8:18           ` Kumar1, Rahul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220210213732.GA25592@wunner.de \
    --to=lukas@wunner.de \
    --cc=Alexander.Deucher@amd.com \
    --cc=Rahul.Kumar1@amd.com \
    --cc=anatoli.antonovitch@amd.com \
    --cc=andrey.grodzovsky@amd.com \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).