From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 822C0C433FE for ; Thu, 10 Feb 2022 21:51:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344532AbiBJVvb (ORCPT ); Thu, 10 Feb 2022 16:51:31 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:38530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238886AbiBJVvb (ORCPT ); Thu, 10 Feb 2022 16:51:31 -0500 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7314FE6B; Thu, 10 Feb 2022 13:51:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644529891; x=1676065891; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=RtABhcfz++1lD4BxroCHUgbb9du3AHo0vVF0UojqTVo=; b=lj/MKt9Bz7XjoX8SUE9donZ1vbJu+AigWl00ZudBIfOYQnCmbOx+JrzD DeY3dankoEV6vNzkXZEJX24R0MuMmPchzMH579PoiFWEUAGEx8scmYBEG tXgnukX1+i1NoyztWTWQnm9w7NrRatsYFhrUDiNGGac6RYY/TiCMHga75 UzWzoSzLWe2ab89FxiINW4Xl6tv0IUB4utbMUmqovoNcV+csDW5ePVPK9 MGo+8fBPhlkVFia5pxPTtTZLefdCREZPJO4ZMMsSXBlMDOG61E6E4cw5t 69zeldo/RWm2JKS9bp7Te4Cw2KodWqf8tyO0Yf2WPnq4KMn1Z7JSReVLN g==; X-IronPort-AV: E=McAfee;i="6200,9189,10254"; a="310337049" X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="310337049" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 13:51:31 -0800 X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="485954165" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 13:51:29 -0800 Date: Thu, 10 Feb 2022 13:51:29 -0800 From: Ira Weiny To: Dan Williams Cc: Jonathan Cameron , Bjorn Helgaas , Alison Schofield , Vishal Verma , Ben Widawsky , Linux Kernel Mailing List , linux-cxl@vger.kernel.org, Linux PCI Subject: Re: [PATCH V6 03/10] PCI/DOE: Add Data Object Exchange Aux Driver Message-ID: <20220210215128.GA998480@iweiny-DESK2.sc.intel.com> Mail-Followup-To: Dan Williams , Jonathan Cameron , Bjorn Helgaas , Alison Schofield , Vishal Verma , Ben Widawsky , Linux Kernel Mailing List , linux-cxl@vger.kernel.org, Linux PCI References: <20220201071952.900068-1-ira.weiny@intel.com> <20220201071952.900068-4-ira.weiny@intel.com> <20220209101320.00000473@Huawei.com> <20220209165756.00002841@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1 (2018-12-01) Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Feb 09, 2022 at 11:57:38AM -0800, Dan Williams wrote: > On Wed, Feb 9, 2022 at 8:58 AM Jonathan Cameron > wrote: > [..] > > > It just seems an unnecessary hunk of code for the core to carry when > > > it's trivial for a client of the core to do: > > > > > > task->private = &completion; > > > task->end_task = complete_completion; > > > submit_task() > > > wait_for_completion(&completion); > > > > OK, we can move this to the callers though function obviously will > > also need renaming - I guess to pci_doe_exchange() and now need to take a > > task rather than the exchange. > > > > I personally slightly prefer the layered approach, but don't care that > > strongly. > > Like I said, you and Ira are holding the pen, so if you decide to keep > the layering, just document the ontology somewhere and I'll let it go. I'm busy with the PKS series ATM but I should get back to reviewing all these comments soon. Ira