From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-kernel@vger.kernel.org, bhelgaas@google.comv,
linux-pci@vger.kernel.org
Cc: paul.walmsley@sifive.com, greentime.hu@sifive.com,
david.abdurachmanov@gmail.com,
Ben Dooks <ben.dooks@codethink.co.uk>
Subject: [PATCH 1/2] PCI: fu740: fix finding GPIOs
Date: Mon, 14 Feb 2022 08:21:43 +0000 [thread overview]
Message-ID: <20220214082144.1176084-2-ben.dooks@codethink.co.uk> (raw)
In-Reply-To: <20220214082144.1176084-1-ben.dooks@codethink.co.uk>
The calls to devm_gpiod_get_optional() have the -gpios at the end of
the name. This means the pcie driver is not finding the necessary
reset or power GPOOs to allow the PCIe devices on the SiFive Unmatched
boards.
This has not been a noted bug as the PCIe probe from u-boot has been
required to get the PCIe working due to other issues with the system
setup. It could have been broken since the driver inclusion, and not
been noticed as it is not necessary for the driver to funciton.
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
drivers/pci/controller/dwc/pcie-fu740.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-fu740.c b/drivers/pci/controller/dwc/pcie-fu740.c
index 00cde9a248b5..842b7202b96e 100644
--- a/drivers/pci/controller/dwc/pcie-fu740.c
+++ b/drivers/pci/controller/dwc/pcie-fu740.c
@@ -259,11 +259,11 @@ static int fu740_pcie_probe(struct platform_device *pdev)
return PTR_ERR(afp->mgmt_base);
/* Fetch GPIOs */
- afp->reset = devm_gpiod_get_optional(dev, "reset-gpios", GPIOD_OUT_LOW);
+ afp->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
if (IS_ERR(afp->reset))
return dev_err_probe(dev, PTR_ERR(afp->reset), "unable to get reset-gpios\n");
- afp->pwren = devm_gpiod_get_optional(dev, "pwren-gpios", GPIOD_OUT_LOW);
+ afp->pwren = devm_gpiod_get_optional(dev, "pwren", GPIOD_OUT_LOW);
if (IS_ERR(afp->pwren))
return dev_err_probe(dev, PTR_ERR(afp->pwren), "unable to get pwren-gpios\n");
--
2.34.1
next prev parent reply other threads:[~2022-02-14 9:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 8:21 fu740 pcie driver fixes Ben Dooks
2022-02-14 8:21 ` Ben Dooks [this message]
2022-02-14 16:05 ` [PATCH 1/2] PCI: fu740: fix finding GPIOs Bjorn Helgaas
2022-02-15 11:21 ` Ben Dooks
2022-02-15 15:20 ` Bjorn Helgaas
2022-02-17 22:15 ` Rob Herring
2022-02-14 8:21 ` [PATCH 2/2] PCI: fu740: Force gen1 for initial device probe Ben Dooks
2022-02-14 16:12 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220214082144.1176084-2-ben.dooks@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=bhelgaas@google.comv \
--cc=david.abdurachmanov@gmail.com \
--cc=greentime.hu@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).