From: Jason Gunthorpe <jgg@nvidia.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Lu Baolu <baolu.lu@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>,
Alex Williamson <alex.williamson@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Christoph Hellwig <hch@infradead.org>,
Kevin Tian <kevin.tian@intel.com>,
Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Dan Williams <dan.j.williams@intel.com>,
rafael@kernel.org, Diana Craciun <diana.craciun@oss.nxp.com>,
Cornelia Huck <cohuck@redhat.com>,
Eric Auger <eric.auger@redhat.com>, Liu Yi L <yi.l.liu@intel.com>,
Jacob jun Pan <jacob.jun.pan@intel.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
Stuart Yoder <stuyoder@gmail.com>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Jonathan Hunter <jonathanh@nvidia.com>,
Li Yang <leoyang.li@nxp.com>, Dmitry Osipenko <digetx@gmail.com>,
iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 04/14] driver core: platform: Add driver dma ownership management
Date: Mon, 14 Feb 2022 09:43:03 -0400 [thread overview]
Message-ID: <20220214134303.GA929467@nvidia.com> (raw)
In-Reply-To: <YgpbC1u6YFN4GefB@kroah.com>
On Mon, Feb 14, 2022 at 02:37:15PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Feb 14, 2022 at 09:18:53AM -0400, Jason Gunthorpe wrote:
> > On Mon, Feb 14, 2022 at 10:59:50AM +0100, Greg Kroah-Hartman wrote:
> >
> > > > + if (ret && !drv->no_kernel_api_dma)
> > > > + iommu_device_unuse_dma_api(dev);
> > >
> > > So you are now going to call this for every platform driver _unless_
> > > they set this flag?
> >
> > Yes, it is necessary because VFIO supports platform devices as well
> > and needs to ensure security. Conflicting kernel driver attachements
> > must be blocked, just like for PCI.
>
> A platform device shouldn't be using VFIO, but ugh, oh well, that ship
> has sailed :(
I don't know why you say that, but yes, this is was set long ago.
> And stop it with the "security" mess, do not give people a false sense
> of it here please.
I'm confused by what you mean. This is all about what we tend to refer
to as DMA security - meaning a device's DMA can be controled by a
hostile environment and not impact the integrity of the kernel.
Jason
next prev parent reply other threads:[~2022-02-14 13:43 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 1:56 [PATCH v5 00/14] Fix BUG_ON in vfio_iommu_group_notifier() Lu Baolu
2022-01-04 1:56 ` [PATCH v5 01/14] iommu: Add dma ownership management interfaces Lu Baolu
2022-01-04 10:08 ` Christoph Hellwig
2022-01-04 16:41 ` Bjorn Helgaas
2022-01-04 19:23 ` Jason Gunthorpe
2022-01-06 3:18 ` Lu Baolu
2022-01-06 3:54 ` Lu Baolu
2022-01-06 15:46 ` Jason Gunthorpe
2022-01-07 1:50 ` Lu Baolu
2022-01-06 3:43 ` Lu Baolu
2022-01-06 3:47 ` Lu Baolu
2022-01-06 3:51 ` Lu Baolu
2022-01-05 6:57 ` Lu Baolu
2022-01-04 1:56 ` [PATCH v5 02/14] driver core: Add dma_cleanup callback in bus_type Lu Baolu
2022-01-04 10:08 ` Christoph Hellwig
2022-01-04 12:39 ` Jason Gunthorpe
2022-01-04 13:04 ` Greg Kroah-Hartman
2022-02-08 5:55 ` Lu Baolu
2022-02-08 11:35 ` Greg Kroah-Hartman
2022-02-14 10:01 ` Greg Kroah-Hartman
2022-02-14 10:02 ` Greg Kroah-Hartman
2022-01-04 1:56 ` [PATCH v5 03/14] amba: Stop sharing platform_dma_configure() Lu Baolu
2022-01-04 1:56 ` [PATCH v5 04/14] driver core: platform: Add driver dma ownership management Lu Baolu
2022-02-14 9:59 ` Greg Kroah-Hartman
2022-02-14 13:18 ` Jason Gunthorpe
2022-02-14 13:37 ` Greg Kroah-Hartman
2022-02-14 13:43 ` Jason Gunthorpe [this message]
2022-01-04 1:56 ` [PATCH v5 05/14] amba: " Lu Baolu
2022-01-04 1:56 ` [PATCH v5 06/14] bus: fsl-mc: " Lu Baolu
2022-01-04 1:56 ` [PATCH v5 07/14] PCI: " Lu Baolu
2022-02-14 10:03 ` Greg Kroah-Hartman
2022-02-14 12:38 ` Jason Gunthorpe
2022-02-14 12:51 ` Greg Kroah-Hartman
2022-02-14 13:11 ` Jason Gunthorpe
2022-02-14 13:39 ` Greg Kroah-Hartman
2022-02-14 13:43 ` Jason Gunthorpe
2022-02-15 3:06 ` Lu Baolu
2022-02-23 18:00 ` Bjorn Helgaas
2022-02-23 18:07 ` Jason Gunthorpe
2022-01-04 1:56 ` [PATCH v5 08/14] PCI: pci_stub: Suppress kernel DMA ownership auto-claiming Lu Baolu
2022-01-04 1:56 ` [PATCH v5 09/14] PCI: portdrv: " Lu Baolu
2022-01-04 17:06 ` Bjorn Helgaas
2022-01-04 19:26 ` Jason Gunthorpe
2022-01-04 19:51 ` Bjorn Helgaas
2022-01-05 0:35 ` Jason Gunthorpe
2022-01-06 4:12 ` Lu Baolu
2022-01-06 18:32 ` Bjorn Helgaas
2022-01-07 1:53 ` Lu Baolu
2022-01-04 1:56 ` [PATCH v5 10/14] vfio: Set DMA ownership for VFIO devices Lu Baolu
2022-01-04 1:56 ` [PATCH v5 11/14] vfio: Remove use of vfio_group_viable() Lu Baolu
2022-01-04 1:56 ` [PATCH v5 12/14] vfio: Delete the unbound_list Lu Baolu
2022-01-04 1:56 ` [PATCH v5 13/14] vfio: Remove iommu group notifier Lu Baolu
2022-01-04 1:56 ` [PATCH v5 14/14] iommu: Remove iommu group changes notifier Lu Baolu
2022-01-04 12:48 ` [PATCH v5 00/14] Fix BUG_ON in vfio_iommu_group_notifier() Jason Gunthorpe
2022-01-05 6:52 ` Lu Baolu
2022-02-18 1:07 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220214134303.GA929467@nvidia.com \
--to=jgg@nvidia.com \
--cc=airlied@linux.ie \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=cohuck@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=daniel@ffwll.ch \
--cc=diana.craciun@oss.nxp.com \
--cc=digetx@gmail.com \
--cc=eric.auger@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=kch@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=laurentiu.tudor@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=stuyoder@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).