From: Jason Gunthorpe <jgg@nvidia.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Yishai Hadas <yishaih@nvidia.com>,
alex.williamson@redhat.com, bhelgaas@google.com,
saeedm@nvidia.com, linux-pci@vger.kernel.org,
kvm@vger.kernel.org, netdev@vger.kernel.org, kuba@kernel.org,
leonro@nvidia.com, kwankhede@nvidia.com, mgurtovoy@nvidia.com,
maorg@nvidia.com, ashok.raj@intel.com, kevin.tian@intel.com,
shameerali.kolothum.thodi@huawei.com
Subject: Re: [PATCH V8 mlx5-next 08/15] vfio: Have the core code decode the VFIO_DEVICE_FEATURE ioctl
Date: Tue, 22 Feb 2022 14:13:26 -0400 [thread overview]
Message-ID: <20220222181326.GD10061@nvidia.com> (raw)
In-Reply-To: <87o82y7sp2.fsf@redhat.com>
On Tue, Feb 22, 2022 at 05:48:57PM +0100, Cornelia Huck wrote:
> One not-that-obvious change this is making is how VFIO_DEVICE_* ioctls
> are processed. With this patch, VFIO_DEVICE_FEATURE is handled a bit
> differently to other ioctl commands that are passed directly to the
> device; here we have the common handling first, then control is passed
> to the device. When I read in Documentation/driver-api/vfio.rst
>
> "The ioctl interface provides a direct pass through for VFIO_DEVICE_*
> ioctls."
Hum. That whole docs section has fallen out of date, the
vfio_device_ops it quotes is quite out of date now.
It is all my fault, I'll send a seperate patch to sort it all after
this is merged.
Maybe we should be converting more of this to kdoc so we don't have
such duplication and it will be more maintainable. That is a bigger
project..
Thanks,
Jason
next prev parent reply other threads:[~2022-02-22 18:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-20 9:57 [PATCH V8 mlx5-next 00/15] Add mlx5 live migration driver and v2 migration protocol Yishai Hadas
2022-02-20 9:57 ` [PATCH V8 mlx5-next 01/15] PCI/IOV: Add pci_iov_vf_id() to get VF index Yishai Hadas
2022-02-20 9:57 ` [PATCH V8 mlx5-next 02/15] net/mlx5: Reuse exported virtfn index function call Yishai Hadas
2022-02-20 9:57 ` [PATCH V8 mlx5-next 03/15] net/mlx5: Disable SRIOV before PF removal Yishai Hadas
2022-02-20 9:57 ` [PATCH V8 mlx5-next 04/15] PCI/IOV: Add pci_iov_get_pf_drvdata() to allow VF reaching the drvdata of a PF Yishai Hadas
2022-02-20 9:57 ` [PATCH V8 mlx5-next 05/15] net/mlx5: Expose APIs to get/put the mlx5 core device Yishai Hadas
2022-02-20 9:57 ` [PATCH V8 mlx5-next 06/15] net/mlx5: Introduce migration bits and structures Yishai Hadas
2022-02-23 19:09 ` Alex Williamson
2022-02-23 19:17 ` Jason Gunthorpe
2022-02-20 9:57 ` [PATCH V8 mlx5-next 07/15] net/mlx5: Add migration commands definitions Yishai Hadas
2022-02-20 9:57 ` [PATCH V8 mlx5-next 08/15] vfio: Have the core code decode the VFIO_DEVICE_FEATURE ioctl Yishai Hadas
2022-02-22 16:48 ` Cornelia Huck
2022-02-22 18:13 ` Jason Gunthorpe [this message]
2022-02-20 9:57 ` [PATCH V8 mlx5-next 09/15] vfio: Define device migration protocol v2 Yishai Hadas
2022-02-22 1:55 ` Tian, Kevin
2022-02-22 23:53 ` Alex Williamson
2022-02-23 0:21 ` Jason Gunthorpe
2022-02-23 1:09 ` Alex Williamson
2022-02-23 2:02 ` Tian, Kevin
2022-02-23 2:47 ` Jason Gunthorpe
2022-02-23 17:06 ` Cornelia Huck
2022-02-24 0:46 ` Jason Gunthorpe
2022-02-24 10:41 ` Cornelia Huck
2022-02-24 12:39 ` Jason Gunthorpe
2022-02-20 9:57 ` [PATCH V8 mlx5-next 10/15] vfio: Extend the device migration protocol with RUNNING_P2P Yishai Hadas
2022-02-22 2:00 ` Tian, Kevin
2022-02-23 17:42 ` Alex Williamson
2022-02-24 0:47 ` Jason Gunthorpe
2022-02-20 9:57 ` [PATCH V8 mlx5-next 11/15] vfio: Remove migration protocol v1 documentation Yishai Hadas
2022-02-20 9:57 ` [PATCH V8 mlx5-next 12/15] vfio/mlx5: Expose migration commands over mlx5 device Yishai Hadas
2022-02-20 9:57 ` [PATCH V8 mlx5-next 13/15] vfio/mlx5: Implement vfio_pci driver for mlx5 devices Yishai Hadas
2022-02-20 9:57 ` [PATCH V8 mlx5-next 14/15] vfio/pci: Expose vfio_pci_core_aer_err_detected() Yishai Hadas
2022-02-20 9:57 ` [PATCH V8 mlx5-next 15/15] vfio/mlx5: Use its own PCI reset_done error handler Yishai Hadas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220222181326.GD10061@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=cohuck@redhat.com \
--cc=kevin.tian@intel.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=maorg@nvidia.com \
--cc=mgurtovoy@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).