From: Bjorn Helgaas <helgaas@kernel.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joerg Roedel <joro@8bytes.org>,
Alex Williamson <alex.williamson@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Christoph Hellwig <hch@infradead.org>,
Kevin Tian <kevin.tian@intel.com>,
Ashok Raj <ashok.raj@intel.com>,
kvm@vger.kernel.org, rafael@kernel.org,
David Airlie <airlied@linux.ie>,
linux-pci@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Diana Craciun <diana.craciun@oss.nxp.com>,
Dmitry Osipenko <digetx@gmail.com>, Will Deacon <will@kernel.org>,
Stuart Yoder <stuyoder@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
Dan Williams <dan.j.williams@intel.com>,
Cornelia Huck <cohuck@redhat.com>,
linux-kernel@vger.kernel.org, Li Yang <leoyang.li@nxp.com>,
iommu@lists.linux-foundation.org,
Jacob jun Pan <jacob.jun.pan@intel.com>,
Daniel Vetter <daniel@ffwll.ch>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v7 05/11] PCI: pci_stub: Set driver_managed_dma
Date: Mon, 28 Feb 2022 13:54:18 -0600 [thread overview]
Message-ID: <20220228195418.GA515725@bhelgaas> (raw)
In-Reply-To: <20220228005056.599595-6-baolu.lu@linux.intel.com>
On Mon, Feb 28, 2022 at 08:50:50AM +0800, Lu Baolu wrote:
> The current VFIO implementation allows pci-stub driver to be bound to
> a PCI device with other devices in the same IOMMU group being assigned
> to userspace. The pci-stub driver has no dependencies on DMA or the
> IOVA mapping of the device, but it does prevent the user from having
> direct access to the device, which is useful in some circumstances.
>
> The pci_dma_configure() marks the iommu_group as containing only devices
> with kernel drivers that manage DMA. For compatibility with the VFIO
> usage, avoid this default behavior for the pci_stub. This allows the
> pci_stub still able to be used by the admin to block driver binding after
> applying the DMA ownership to VFIO.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> drivers/pci/pci-stub.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/pci-stub.c b/drivers/pci/pci-stub.c
> index e408099fea52..d1f4c1ce7bd1 100644
> --- a/drivers/pci/pci-stub.c
> +++ b/drivers/pci/pci-stub.c
> @@ -36,6 +36,7 @@ static struct pci_driver stub_driver = {
> .name = "pci-stub",
> .id_table = NULL, /* only dynamic id's */
> .probe = pci_stub_probe,
> + .driver_managed_dma = true,
> };
>
> static int __init pci_stub_init(void)
> --
> 2.25.1
>
> _______________________________________________
> iommu mailing list
> iommu@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-02-28 19:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 0:50 [PATCH v7 00/11] Fix BUG_ON in vfio_iommu_group_notifier() Lu Baolu
2022-02-28 0:50 ` [PATCH v7 01/11] iommu: Add DMA ownership management interfaces Lu Baolu
2022-03-04 10:34 ` Eric Auger
2022-03-04 10:43 ` Lu Baolu
2022-03-04 12:22 ` Robin Murphy
2022-03-04 13:55 ` Eric Auger
2022-03-04 14:10 ` Robin Murphy
2022-03-07 3:27 ` Lu Baolu
2022-03-07 12:42 ` Eric Auger
2022-03-08 0:31 ` Lu Baolu
2022-02-28 0:50 ` [PATCH v7 02/11] driver core: Add dma_cleanup callback in bus_type Lu Baolu
2022-02-28 0:50 ` [PATCH v7 03/11] amba: Stop sharing platform_dma_configure() Lu Baolu
2022-02-28 0:50 ` [PATCH v7 04/11] bus: platform,amba,fsl-mc,PCI: Add device DMA ownership management Lu Baolu
2022-02-28 0:50 ` [PATCH v7 05/11] PCI: pci_stub: Set driver_managed_dma Lu Baolu
2022-02-28 19:54 ` Bjorn Helgaas [this message]
2022-02-28 0:50 ` [PATCH v7 06/11] PCI: portdrv: " Lu Baolu
2022-02-28 19:56 ` Bjorn Helgaas
2022-03-01 2:54 ` Lu Baolu
2022-02-28 0:50 ` [PATCH v7 07/11] vfio: Set DMA ownership for VFIO devices Lu Baolu
2022-02-28 22:06 ` Alex Williamson
2022-02-28 0:50 ` [PATCH v7 08/11] vfio: Remove use of vfio_group_viable() Lu Baolu
2022-02-28 22:06 ` Alex Williamson
2022-02-28 0:50 ` [PATCH v7 09/11] vfio: Delete the unbound_list Lu Baolu
2022-02-28 22:06 ` Alex Williamson
2022-02-28 0:50 ` [PATCH v7 10/11] vfio: Remove iommu group notifier Lu Baolu
2022-02-28 22:06 ` Alex Williamson
2022-02-28 0:50 ` [PATCH v7 11/11] iommu: Remove iommu group changes notifier Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220228195418.GA515725@bhelgaas \
--to=helgaas@kernel.org \
--cc=airlied@linux.ie \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=cohuck@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=daniel@ffwll.ch \
--cc=diana.craciun@oss.nxp.com \
--cc=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=jgg@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=kch@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=stuyoder@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).