Re: [PATCH v4 2/8] dmaengine: dw-edma: remove unused field irq in struct dw_edma_chip

[Serge Semin <fancer.lancer@gmail.com>]

On Wed, Mar 09, 2022 at 03:11:58PM -0600, Frank Li wrote:

> irq of struct dw_edma_chip was never used.
> It can be removed safely.

The patch is incomplete. See drivers/dma/dw-edma/dw-edma-pcie.c:234.
The irq field is initialized there. But it's never used afterwards. So
you need to fix the dw-edma-pcie.c driver too by dropping the
corresponding initialization, otherwise the driver will fail to be
built.

-Sergey

> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> new patch at v4
> 
>  include/linux/dma/edma.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/dma/edma.h b/include/linux/dma/edma.h
> index a9bee4aeb2eee..6fd374cc72c8e 100644
> --- a/include/linux/dma/edma.h
> +++ b/include/linux/dma/edma.h
> @@ -37,7 +37,6 @@ enum dw_edma_map_format {
>   * struct dw_edma_chip - representation of DesignWare eDMA controller hardware
>   * @dev:		 struct device of the eDMA controller
>   * @id:			 instance ID
> - * @irq:		 irq line
>   * @nr_irqs:		 total dma irq number
>   * @ops			 DMA channel to IRQ number mapping
>   * @wr_ch_cnt		 DMA write channel number
> @@ -51,7 +50,6 @@ enum dw_edma_map_format {
>  struct dw_edma_chip {
>  	struct device		*dev;
>  	int			id;
> -	int			irq;
>  	int			nr_irqs;
>  	const struct dw_edma_core_ops   *ops;
>  
> -- 
> 2.24.0.rc1
>